feat: add feature "fancy-no-syscall" for wasm targets #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
approved these changes
Feb 23, 2024
|
Thank you! I'll test this in my project tomorrow, let's make a release after I've confirmed the |
|
I have verified both features |
|
@zkat A new release would be greatly appreciated 🤝 |
|
@Boshen done. Should be out in 7.2.0 now. |
github-merge-queue bot
pushed a commit
to microsoft/qsharp
that referenced
this pull request
Aug 27, 2024
Closes #1887 Thanks @billti for finding the new `fancy-no-syscall` feature [introduced to `miette` in February](zkat/miette#349). As a result of that change, we can now update to the latest version of `miette` without breaking our WASM builds. Yay!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
terminal_size#346supports_color::onwhen color is forced #326I added
fancy-basefeature to enable exports for thefancyfeaturefancy-no-syscallfeature to disable all syscallswasmci check to ensure future changes.target_family = "wasm"will not work in this case becauseterminal_sizewill not compile underwasm32-unknown-unknown, the dependency has to be excluded.