Add TryFrom<[u8; 32]> implementations for Scalar and EdwardsPoint #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of importing `Debug` directly and fully-qualifying fmt via `::core::fmt` in other places, we bring the whole `core::fmt` module into scope and refer to `Formatter` and `Result` as `fmt::Formatter` and `fmt::Result`.
Although not strictly required by trait-bounds, we introduce a dedicated error type in case the conversion fails. If the `std` feature is enabled, this error type implements `std::error::Error`. Having a dedicated error type improves ergonomics a lot as many uses of `TryFrom` imply `TryFrom::Error: std::error::Error`. We don't alter the original APIs of `Scalar` and `EdwardsPoint` to maintain backwards compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch is a minor cleanup.
Second patch adds the functionality claimed in the title.