feat: add build and dev-setup scripts for email auth reveal circuit#134
Closed
zkfriendly wants to merge 3 commits intoemail-recoveryfrom
Closed
feat: add build and dev-setup scripts for email auth reveal circuit#134zkfriendly wants to merge 3 commits intoemail-recoveryfrom
zkfriendly wants to merge 3 commits intoemail-recoveryfrom
Conversation
shreyas-londhe
requested changes
Jun 2, 2025
packages/circuits/package.json
Outdated
| "scripts": { | ||
| "build": "mkdir -p build && circom src/email_auth.circom --r1cs --wasm --sym --c -l ../../node_modules -o ./build", | ||
| "build-no-timestamp": "mkdir -p build/no-timestamp && circom src/email_auth_no_timestamp.circom --r1cs --wasm --sym --c -l ../../node_modules -o ./build/no-timestamp", | ||
| "build-reveal": "mkdir -p build/reveal && circom src/email_auth_reveal.circom --r1cs --wasm --sym --c -l ../../node_modules -o ./build/reveal", |
Member
There was a problem hiding this comment.
suggestion: This looks okay for now, but if we plan to add more scripts in the future, maybe a good design would be to write a CLI script for all the build and dev setups with arguments instead of adding unique commands. This would be more modular and easy to work with as well.
Collaborator
Author
|
closing in favor of #146 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add build and setup scripts