Skip to content

[myt/wacca] remove version compat code #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zkldi merged 1 commit into from
May 8, 2025
Merged

[myt/wacca] remove version compat code #1292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions server/src/lib/score-import/import-types/api/myt-wacca/class-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,16 @@ export default async function CreateMytWACCAClassHandler(
const data = dataRes;

return (_gptString, _userID, _ratings, _logger) => {
// In Apr/May 2025, the keys for version data are changing from
// 0-indexed (starting at WACCA) to custom enum values.
// TODO: Once MYT transitions over to the new enum, remove the _OLD
// values from the enum proto definition, and remove the compatibility
// code below.
// Currently (Apr. 2025) Reverse and Plus are supported on Myt.
// Currently (May 2025) Reverse and Plus are supported on Myt.
// We look for both Reverse and PLUS version data, PLUS being prioritized if exists.
// If / when custom dans are added, this will need to change.
const versionDataMap = data.getVersionDataMap();
let versionData: DataResponse.VersionData | undefined;

if (versionDataMap.has(WaccaVersion.WACCA_VERSION_PLUS)) {
versionData = versionDataMap.get(WaccaVersion.WACCA_VERSION_PLUS);
} else if (versionDataMap.has(WaccaVersion.WACCA_VERSION_PLUS_OLD)) {
versionData = versionDataMap.get(WaccaVersion.WACCA_VERSION_PLUS_OLD);
} else if (versionDataMap.has(WaccaVersion.WACCA_VERSION_REVERSE)) {
versionData = versionDataMap.get(WaccaVersion.WACCA_VERSION_REVERSE);
} else if (versionDataMap.has(WaccaVersion.WACCA_VERSION_REVERSE_OLD)) {
versionData = versionDataMap.get(WaccaVersion.WACCA_VERSION_REVERSE_OLD);
}

// rank:
Expand Down
5 changes: 0 additions & 5 deletions server/src/proto/generated/wacca/common_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,6 @@ export namespace WaccaJudge {

export interface WaccaVersionMap {
WACCA_VERSION_UNSPECIFIED: 0;
WACCA_VERSION_S_OLD: 1;
WACCA_VERSION_LILY_OLD: 2;
WACCA_VERSION_LILY_R_OLD: 3;
WACCA_VERSION_REVERSE_OLD: 4;
WACCA_VERSION_PLUS_OLD: 5;
WACCA_VERSION_WACCA: 100;
WACCA_VERSION_S: 150;
WACCA_VERSION_LILY: 200;
Expand Down
5 changes: 0 additions & 5 deletions server/src/proto/generated/wacca/common_pb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,11 +544,6 @@ proto.mythos.wacca.v0.WaccaJudge.prototype.setMiss = function(value) {
*/
proto.mythos.wacca.v0.WaccaVersion = {
WACCA_VERSION_UNSPECIFIED: 0,
WACCA_VERSION_S_OLD: 1,
WACCA_VERSION_LILY_OLD: 2,
WACCA_VERSION_LILY_R_OLD: 3,
WACCA_VERSION_REVERSE_OLD: 4,
WACCA_VERSION_PLUS_OLD: 5,
WACCA_VERSION_WACCA: 100,
WACCA_VERSION_S: 150,
WACCA_VERSION_LILY: 200,
Expand Down
8 changes: 0 additions & 8 deletions server/src/proto/myt/wacca/common.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,6 @@ package mythos.wacca.v0;

enum WaccaVersion {
WACCA_VERSION_UNSPECIFIED = 0;

// TODO: once MYT transitions over to the new enum, remove the _OLD values
WACCA_VERSION_S_OLD = 1;
WACCA_VERSION_LILY_OLD = 2;
WACCA_VERSION_LILY_R_OLD = 3;
WACCA_VERSION_REVERSE_OLD = 4;
WACCA_VERSION_PLUS_OLD = 5;

WACCA_VERSION_WACCA = 100;
WACCA_VERSION_S = 150;
WACCA_VERSION_LILY = 200;
Expand Down
Loading