ZK-5824: separate fragment widget into an independent library or anot… #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 16 out of 31 changed files in this pull request and generated no comments.
Files not reviewed (15)
- zkdoc/release-note: Language not supported
- zktest/src/main/webapp/test2/B85-ZK-3840.zul: Language not supported
- zktest/src/main/webapp/test2/B86-ZK-3996.zul: Language not supported
- zktest/src/main/webapp/test2/B86-ZK-4014.zul: Language not supported
- zktest/src/main/webapp/test2/B86-ZK-4025.zul: Language not supported
- zktest/src/main/webapp/test2/B86-ZK-4031.zul: Language not supported
- zktest/src/main/webapp/test2/F85-ZK-3681-Command.zul: Language not supported
- zktest/src/main/webapp/test2/F85-ZK-3681-Component.zul: Language not supported
- zktest/src/main/webapp/test2/F85-ZK-3681-Databinding.zul: Language not supported
- zktest/src/main/webapp/test2/F85-ZK-3681-Jsvalidator.zul: Language not supported
- zktest/src/main/webapp/test2/F85-ZK-3681-Shadow.zul: Language not supported
- zktest/src/main/webapp/test2/F85-ZK-3681-Validator-Form.zul: Language not supported
- zktest/src/main/webapp/test2/F85-ZK-3681-Validator.zul: Language not supported
- zktest/src/main/webapp/test2/F85-ZK-3780.zul: Language not supported
- zktest/src/main/java/org/zkoss/zktest/test2/B86_ZK_4014VM.java: Evaluated as low risk
jumperchen
force-pushed
the
ZK-5824
branch
2 times, most recently
from
d62f437 to
96f4a16
Compare
|
Test result: all passed except four issues. Three of these can be resolved through manual testing, while B96_ZK_5423Test is another bug not related to this PR. |
jumperchen
changed the title
rebecca0201
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…her jar
This should be merged alongside https://github.com/zkoss/zkcml/pull/1210