Minimize Calls of getRefObj/getLinkObj

Products/zms/_objattrs.py

@@ -570,12 +570,12 @@ def getObjProperty(self, key, REQUEST={}, par=None):
         datatype = obj_attr['datatype_key']
         value = self.getObjAttrValue( obj_attr, REQUEST)
         if value:
-          # Text-Fields
-          if datatype in _globals.DT_TEXTS:
-            value = self.validateInlineLinkObj(value)
-          # Url-Fields
-          if datatype == _globals.DT_URL:
-            value = self.validateLinkObj(value)
+          # Text-Fields: validate inline-links (skip in manage to avoid redundant getLinkObj calls)
+          if datatype in _globals.DT_TEXTS and not standard.isManagementInterface(self):
+              value = self.validateInlineLinkObj(value)
+          # Url-Fields: validate link-attributes (skip in manage to avoid redundant getLinkObj calls)
+          if datatype == _globals.DT_URL and not standard.isManagementInterface(self):
+              value = self.validateLinkObj(value)
           # Executable fields.
           value = standard.dt_exec(self, value)
 

Products/zms/_zreferableitem.py

@@ -23,6 +23,8 @@
 # Product Imports.
 from Products.zms import standard
 from zope.globalrequest import getRequest
+# FOR DEBUGGING PURPOSES ONLY: import traceback to log the call stack of getLinkObj calls
+import traceback
 
 # ------------------------------------------------------------------------------
 #  isMailLink:
@@ -502,30 +504,55 @@ def getLinkObj(self, url, REQUEST=None):
         i = max(url.find('#'),url.find(','))
         if i > 0:
           url = url[:i]
-        if url.find('id:') >= 0:
-          catalog = self.getZMSIndex().get_catalog()
-          q = catalog({'get_uid':url})
-          for r in q:
-            path  = '%s/'%r['getPath']
+        #-- [ReqBuff]: Fetch buffered value from Http-Request.
+        reqBuffId = 'getLinkObj.%s'%url
+        try:
+          ob = self.getDocumentElement().fetchReqBuff(reqBuffId)
+        except:
+          if url.find('id:') >= 0:
+            catalog = self.getZMSIndex().get_catalog()
+            q = catalog({'get_uid':url})
+            for r in q:
+              path  = '%s/'%r['getPath']
+              l = [x for x in path.split('/') if x] 
+              ob = self.getRootElement()
+              if l:
+                [l.pop(0) for x in ob.getPhysicalPath() if l[0] == x]
+                for id in l:
+                  ob = getattr(ob,id,None)
+              break
+          elif not url.startswith('__'):
+            path = url.replace('@','/content/')
             l = [x for x in path.split('/') if x] 
-            ob = self.getRootElement()
+            ob = self.getDocumentElement()
             if l:
               [l.pop(0) for x in ob.getPhysicalPath() if l[0] == x]
               for id in l:
                 ob = getattr(ob,id,None)
-            break
-        elif not url.startswith('__'):
-          path = url.replace('@','/content/')
-          l = [x for x in path.split('/') if x] 
-          ob = self.getDocumentElement()
-          if l:
-            [l.pop(0) for x in ob.getPhysicalPath() if l[0] == x]
-            for id in l:
-              ob = getattr(ob,id,None)
-      # Prepare request
-      ids = self.getPhysicalPath()
-      if ob is not None and ob.id not in ids:
-        ob.set_request_context(request, ref_params)
+          #-- [ReqBuff]: Store value in buffer of Http-Request.
+          self.getDocumentElement().storeReqBuff(reqBuffId, ob)
+      # Prepare request (only if ref_params are provided)
+      if ob is not None and ref_params:
+        ids = self.getPhysicalPath()
+        if ob.id not in ids:
+          ob.set_request_context(request, ref_params)
+      # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+      # DEBUG: logging/counting getLinkObj calls
+      # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+      request.set('getLinkObj_counter', request.get('getLinkObj_counter', 0) + 1)
+      # show traceback in debugging output to identify which function is  calling getLinkObj and causing multiple calls
+      traceback_stack = []
+      for frame in reversed(traceback.extract_stack()[-5:-2]):
+        traceback_stack.append('%s:%s:%s' % (str(frame.filename).split('/')[-1], frame.lineno, frame.name))
+      standard.writeStdout(self, '%d. [getLinkObj] %s, ID=%s, ref_params=%s\n...was called from:\n\t%s\n'%(
+        request.get('getLinkObj_counter', 0),
+        url, 
+        ob.id if ob is not None else None, 
+        ref_params,
+        '\n\t'.join(traceback_stack)
+        )
+      )
+      # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     return ob
 
 

Products/zms/version.txt

@@ -1 +1 @@
-2025.9.1+b976ca4
+2025.9.1+e8eb17b

Products/zms/zmslinkelement.py

@@ -193,12 +193,18 @@ def getRef(self):
     #  ZMSLinkElement.getRefObj:
     # --------------------------------------------------------------------------
     def getRefObj(self):
+      #-- [ReqBuff]: Fetch buffered value from Http-Request.
+      docelmnt = self.getDocumentElement()
+      reqBuffId = 'getRefObj.%s'%self.get_uid()
+      try: return docelmnt.fetchReqBuff(reqBuffId)
+      except: pass
       ref_obj = self.getLinkObj(self.getRef())
       if ref_obj == self:
         ref_obj = None
       if ref_obj is not None and ref_obj.meta_type == 'ZMSLinkElement':
         ref_obj = ref_obj.getRefObj()
-      return ref_obj
+      #-- [ReqBuff]: Returns value and stores it in buffer of Http-Request.
+      return docelmnt.storeReqBuff(reqBuffId, ref_obj)
 
 
     # --------------------------------------------------------------------------