Repository navigation
build: align tooling and gitignore with the release baseline - #111
Merged
Merged
Conversation
golangci-lint-action was invoked without a `version:` input, so CI always installed the newest release. That makes the pipeline fail on an upstream release with no change here, and it silently diverges from the v2.12.1 the Makefile already pinned. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
publish.yml could only be triggered by a push to main, so the credentials it needs could not be verified on demand. An expired HELM_CHARTS_REPO_TOKEN went unnoticed for weeks because nothing happened to land on main during that window, and it only surfaced when an unrelated change did. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Two gaps against the other operators: - `make helm-chart-package` writes to target/, which this repo did not ignore - one of only two operators in that state. - .omc/ is ignored everywhere else; this was the only operator missing it. Both matter now that check-crds-sync stages untracked files before diffing: leftover output from a local chart or agent run would be reported as CRD drift. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part of the 0.4.0 release baseline alignment.
golangci-lint was floating.
golangci-lint-actionwas invoked with noversion:input, so CI always installed the newest release. That breaks thepipeline on an upstream release with no change here, and it diverges from the
v2.12.1 the Makefile already pinned.
Two gitignore gaps.
make helm-chart-packagewrites totarget/, whichthis repo did not ignore — one of only two operators in that state.
.omc/isignored in every other operator; this was the only one missing it. Both matter
now that
check-crds-syncstages untracked files before diffing: leftoveroutput from a local chart or agent run gets reported as CRD drift.
publish.yml could only be triggered by a push to main, so its credentials
could not be verified on demand. That is how an expired
HELM_CHARTS_REPO_TOKENwent unnoticed for weeks — nothing landed on main to exercise it, and it only
surfaced when an unrelated change did.
workflow_dispatchmakes the publishpath verifiable before a release rather than at tag time, when the tag cannot
be recut.
Verification
make lint(v2.12.1)make testcheck-crds-sync(simulated per the CI logic, clean tree)make helm-crd-syncworkflow_dispatchparses as expected🤖 Generated with Claude Code