Merged
Conversation
- Fixed the logic in the gemspec file to correctly compare the current Ruby version with the required version. - Replaced string comparison of `RUBY_VERSION` with `Gem::Version` for better semantic version handling. - Addressed edge cases, such as "3.10" being greater than "3.2". Why: The previous comparison caused a `LoadError` for `syntax_suggest` on Ruby 3.1.6 due to incorrect string-based version comparison. RUBY_VERSION returns a string, not a comparable version, breaking the current comparison in some cases.
- `”syntax_suggest", "~> 1.1.0"` to `”syntax_suggest", ">= 1.1.0"` in the gemspec Why: Allows greater flexibility for users by supporting newer versions of `syntax_suggest` beyond the `1.x` range, especially as 2.x requires ruby >= 3.0
Contributor
|
Thanks! I appreciate the detailed notes. I'm going accept this - the ruby/rails_head test failure is already addressed in main |
pcai
added a commit
that referenced
this pull request
Jan 1, 2025
pcai
added a commit
that referenced
this pull request
Jan 1, 2025
pcai
added a commit
that referenced
this pull request
Jan 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RUBY_VERSIONwithGem::Versionfor better semantic version handling.Why:
The previous comparison caused a
LoadErrorforsyntax_suggeston Ruby 3.1.6 due to string-based version comparison. RUBY_VERSION returns a string, not a comparable version, breaking the current comparison in some cases.