Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #12 - Dependency clashes #31

Merged
merged 5 commits into from
Jan 3, 2019
Merged

Fixes #12 - Dependency clashes #31

merged 5 commits into from
Jan 3, 2019

Conversation

simmo
Copy link
Contributor

@simmo simmo commented Jan 2, 2019 •
edited
Loading

What does this PR cover?
Bugfix

Breaking change?
Yes

Are all the tests are passing?
No

Other information:

  • Support node engines not specified in package.json to match CI build targets.
  • Reverted back to peer dependencies
  • Updating eslint and eslint-plugin-react to latest
  • Resolving conflicts
  • Tweaking peer dependencies to offer greater compatibility

@simmo simmo added the bug Something isn't working label Jan 2, 2019
@simmo simmo added this to the 4.0.0 milestone Jan 2, 2019
@simmo simmo self-assigned this Jan 2, 2019
@simmo simmo requested review from sburrows-zone and a team January 2, 2019 18:57
@simmo simmo merged commit 3715c19 into develop Jan 3, 2019
@simmo simmo deleted the feature/12-dependency-clashes branch January 3, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinherweg martinherweg martinherweg approved these changes

@arashkiani arashkiani arashkiani approved these changes

@sburrows-zone sburrows-zone Awaiting requested review from sburrows-zone

Assignees

@simmo simmo

Labels
bug Something isn't working
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simmo @martinherweg @arashkiani