Skip to content

Tutorial: fix navigation breaking when too many steps #6799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

shaunanoordin
Copy link
Member

@shaunanoordin shaunanoordin commented Mar 26, 2025

PR Overview

Package: lib-classifier
Closes #6798

This PR provides a rudimentary fix for the Tutorial system's StepNavigation, to prevent the Tutorial UI from completely breaking when a tutorial has too many steps.

Before this patch:

Image

After this patch:

Image
(Previous solution:) Image

This solution was replaced after this comment.

Status

Ready for review.

@coveralls
Copy link

coveralls commented Mar 26, 2025

Coverage Status

coverage: 75.545% (-0.03%) from 75.572%
when pulling f72805d on tutorial-paging-improvement
into 8170324 on master.

@shaunanoordin
Copy link
Member Author

PR Update

Better idea from Sean: wrap excessive page buttons into a second(+) row(s).

Image

Copy link
Contributor

@goplayoutside3 goplayoutside3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the approved This PR is approved for merging label Mar 29, 2025
@shaunanoordin shaunanoordin force-pushed the tutorial-paging-improvement branch from b79fd81 to f72805d Compare March 31, 2025 15:06
@shaunanoordin shaunanoordin merged commit b8175ee into master Mar 31, 2025
7 checks passed
@shaunanoordin shaunanoordin deleted the tutorial-paging-improvement branch March 31, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial: navigation borks when there are too many steps
3 participants