Add zos options cat #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachintu47
requested review from
IgorTodorovskiIBM and
MikeFultonDev
as code owners
|
|
||
| +#ifdef __MVS__ | ||
| +if (!ccsid_info.cmd_arg) { | ||
| + const char *env = getenv("_TEXT_CONV"); |
Member
There was a problem hiding this comment.
Should this be documented in the same place as the options?
Contributor
Author
There was a problem hiding this comment.
Yes. It should be. I'll make this change in the next PR
IgorTodorovskiIBM
approved these changes
Apr 10, 2025
Member
IgorTodorovskiIBM
left a comment
IgorTodorovskiIBM
left a comment
There was a problem hiding this comment.
LGTM overall, great work. I have one comment about _TEXT_CONV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add -B and -W options to cat command according to https://www.ibm.com/docs/en/zos/2.4.0?topic=descriptions-cat-concatenate-display-files