Skip to content

WIP: Implement sections remote-control and pattern and a few small bugfixes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP: Implement sections remote-control and pattern and a few small bugfixes #2

wants to merge 4 commits into from

Conversation

MEschenbacher
Copy link

@MEschenbacher MEschenbacher commented May 12, 2021 •
edited
Loading

TODO

  • documentation
  • examples

@MEschenbacher MEschenbacher changed the title Implement sections remote-control and pattern and a few small bugfixes WIP: Implement sections remote-control and pattern and a few small bugfixes May 12, 2021
@zorun
Copy link
Owner

zorun commented May 13, 2021

It looks good. nsd_local_remote_control_config is a bit unfortunate but it's consistent with the rest.

Why do you need a "quoteless" variant of the template macro?

Also, if I understand correctly, you are using this on an OS other than Debian? Feel free to update meta/main.yml accordingly.

@MEschenbacher MEschenbacher force-pushed the sections branch 2 times, most recently from bb2eca7 to 436d3fb Compare May 14, 2021 09:20
@MEschenbacher
support sections remote-control and pattern
46f7a99 
this commit introduces a few changes namely:

- a new macro which prints values without quotes (required for patterns)
- the configuration files and zone files are no longer validated since
  they depend on one another and will fail to validate in case of
  changes to one file which depends on a not yet written change of
  another file
@MEschenbacher
use the generic ansible 'package' module
9627920
@MEschenbacher
File owner and group are now configurable
7122f66
@MEschenbacher
tsigkey_config.j2 is unused
d2154c1
@MEschenbacher
Copy link
Author

I rewrote the new sections but the still require a quoteless version. The quoteless version is required because there are a few options which take more than one argument.

I'll think about it some more, do some more testing. Maybe I can strip this monster down to a more readable version.

@MEschenbacher
Copy link
Author

Has been working fine so far. I'm still unhappy about the zone.include_pattern vs. include-pattern: ... naming conflict. It is quite common to replace all dashes in configuration options with underscores but this role has been able to avoid that so far I'd like to keep it that way.

@zorun
Copy link
Owner

zorun commented Dec 30, 2022

Hi @MEschenbacher , I hadn't looked at this recently. What is the status, is it still WIP?

I suggest submitting the FreeBSD changes separately, that's much easier to review/merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MEschenbacher @zorun