Define string_theory target only if it doesn't exist yet
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes errors when another project does find_package(string_theory) more than once, usually indirectly through another dependency. This happened for MoulKI for example, which depends on string_theory both directly and indirectly through libHSPlasma.
|
No idea why the Linux CI is sad, but that has nothing to do with my change - the error is somewhere inside the GoogleTest code. The Solaris CI also seems to be stuck on... something. It's not even booting up apparently? |
|
oh hey! I just ran into this yesterday with another project 😅 |
zrax
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes errors when another project does
find_package(string_theory)more than once, usually indirectly through another dependency. This happened for MoulKI for example, which depends on string_theory both directly and indirectly through libHSPlasma.