update xml_sitemap_writer to 0.6.0 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.5.0 is incompatible with python 3.12 and more recent, with the following error observed in CI:
```
Traceback (most recent call last):
File "/builds/gasche/types-chat-archive/zulip-archive/archive.py", line 52, in <module>
from lib.sitemap import build_sitemap
File "/builds/gasche/types-chat-archive/zulip-archive/lib/sitemap.py", line 4, in <module>
from xml_sitemap_writer import XMLSitemap
File "/root/.local/lib/python3.13/site-packages/xml_sitemap_writer.py", line 8, in <module>
from typing.io import IO # pylint:disable=import-error
```
(The incompatibility is due to the removal of 'typing.io' in 3.12, see [here](Almenon/AREPL-vscode#416 (comment)) for some discussion.)
I have checked manually that the zulip-archive works fine with xml_sitemap_writer 0.6.0, which supports python 3.12 and 3.13.
|
Merged, thanks for the PR @gasche! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.5.0 is incompatible with python 3.12 and more recent, with the following error observed in CI:
(The incompatibility is due to the removal of 'typing.io' in 3.12, see here for some discussion.)
I have checked manually that the zulip-archive works fine with xml_sitemap_writer 0.6.0, which supports python 3.12 and 3.13.