KaTeX (2/n): Support horizontal and vertical offsets for spans #1452
+607
−275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajveermalviya
force-pushed
the
pr-tex-content-2
branch
from
d00e10f to
7ff4f9e
Compare
rajveermalviya
force-pushed
the
pr-tex-content-2
branch
from
7ff4f9e to
c0dd0a1
Compare
This way there's nothing that needs to happen at the bottom of the loop, if any of the cases matched.
Conveniently, the two redundant rules say the exact same thing when they apply. So the first one has no effect, and we can ignore it.
Before this change, all cases of this switch statement either continue the loop, or throw, or set classFound to true. The error therefore gets logged just if none of the cases matched. So we can express the same behavior with a default case.
This makes the reasoning about these index values more local.
Like an early return, this (a) brings the consequence of the error immediately next to the condition defining it, and (b) lets the normal happy case continue vertically down without adding indentation.
Same motivation as in the parent commit.
Once the parsing is done, we want these to remain unchanged, just like the other objects in the parse tree. So, like ContentNode and its subclasses, make the class immutable. The parser needs to mutate its own draft of what styles to apply to a given span; but it can do that with its own local variables corresponding to the fields, and construct a styles object at the end of the loop.
This deduplicates the logic for the particular way that a list of KaTeX nodes get combined into a single widget.
This makes it more uniform with our other content widgets.
gnprice
reviewed
Apr 22, 2025
Comment on lines
+372
to
+376
| sealed class KatexNode extends ContentNode { | ||
| const KatexNode({super.debugHtmlNode}); | ||
| } | ||
|
|
||
| class KatexSpanNode extends KatexNode { |
There was a problem hiding this comment.
One point that I noticed while developing #1478 (and checking how my draft of that branch interacted with this PR): it'd be good for this commit:
e268041 content: Handle vertical offset spans in KaTeX content
to get split up like so:
- First, an NFC prep commit introduces the distinction between KatexNode and KatexSpanNode. At this stage, the latter is the only subclass of the former.
- Then another commit makes the substantive changes this commit is about, including introducing the sibling subclasses KatexVlistNode and KatexVlistRowNode.
One reason that'd be useful is that the split between KatexNode and KatexSpanNode is somewhat nontrivial in itself: some of the references to KatexNode continue to say KatexNode, while others switch to saying KatexSpanNode, so the commit is expressing meaningful information by its choices of which references go which way.
This applies the correct font scaling if the KaTeX content is inside a header.
rajveermalviya
force-pushed
the
pr-tex-content-2
branch
from
c0dd0a1 to
b17033a
Compare
And rename previous type to KatexSpanNode, also while making it a subtype of KatexNode.
Implement handling most common types of `vlist` spans.
Negative margin spans on web render to the offset being applied to the specific span and all the adjacent spans, so mimic the same behaviour here.
rajveermalviya
force-pushed
the
pr-tex-content-2
branch
from
b17033a to
16cb28f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of: #1408
Related: #46