msglist: Friendlier placeholder text when narrow has no messages #1640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
force-pushed
the
pr-empty-msglist-placeholder
branch
from
1e9c27d to
416787a
Compare
|
Revision pushed, incorporating Vlad's new design with larger "header" text and smaller "message" text: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=11194-18392&m=dev I've updated the screenshots. |
We can reuse this for the empty message list.
Fixes zulip#1555. For now, the text simply says "There are no messages here." We'll add per-narrow logic later, but this is an improvement over the current appearance which just says "No earlier messages." (Earlier than what?) To support being used in the message-list page (in addition to Inbox, etc.), the placeholder widget only needs small changes, it turns out.
Following a new Figma frame that specifies larger text for the first part: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=11194-18392&m=dev The smaller text is left optional. The subscriptions page has a plan to add that smaller text, as a TODO(zulip#188); it's blocked on adding an "All channels" page.
chrisbobbe
force-pushed
the
pr-empty-msglist-placeholder
branch
from
416787a to
e2c3ab5
Compare
rajveermalviya
approved these changes
Jul 2, 2025
| if (learnMoreButtonUrl != null) | ||
| ZulipWebUiKitButton( | ||
| label: zulipLocalizations.learnMoreButtonLabel, | ||
| onPressed: () => ZulipBinding.instance.launchUrl(learnMoreButtonUrl!)), |
There was a problem hiding this comment.
I think we should use PlatformActions.launchUrl here to follow user's browser preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked atop #1650 and #1652.
Fixes #1653.
Done using web as a guide for the conditional logic.
Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=11194-18392&m=dev
cc @alya
Screenshots
Starred messages: "Learn more" button opens
/help/star-a-messageMentions: web shows more text here, but there's complexity around what kind of mentions are supported; I've left a TODO for later.
Group DM:
Group DM with a deactivated user:
DM with muted user:
DM with deactivated user:
Unknown channel (unknown because I'm not allowed to know about it):
Private channel I'm not subscribed to: "Learn more" button goes to
/help/channel-permissions#private-channels(The error banner replacing the compose box is also new in this PR. It's the same as the one above, for unknown channels, which is in
main.)