Skip to content

msglist: In keyword search narrow, highlight keywords in message content #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chrisbobbe
Copy link
Collaborator

@chrisbobbe chrisbobbe commented Jul 9, 2025

Fixes #1692.

Still TODO:

But otherwise I think this is ready.

—Oh no, hmm, the code-blocks issue #1695 might need to block this after all; it's ugly when there's a match in a code block:

image

Figma for what highlighting should look like: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=10904-102304&m=dev


Light Dark
image image

cc @alya to look at the screenshots.

@chrisbobbe chrisbobbe requested a review from gnprice July 9, 2025 06:37
@chrisbobbe chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search: Highlight matches in content
2 participants