unreads: Add/use locatorMap, to efficiently locate messages #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
a-model
rajveermalviya
approved these changes
Jul 14, 2025
lib/model/unreads.dart
Outdated
| DmMessage() => DmNarrow.ofMessage(message, selfUserId: selfUserId), | ||
| }; | ||
| locatorMap[event.message.id] = narrow; | ||
|
|
There was a problem hiding this comment.
nit: maybe merge both switches? To avoid a copy of DmNarrow and more specifically of allRecipientIds list in DmNarrow.ofMessage.
switch (message) {
case StreamMessage():
final narrow = TopicNarrow.ofMessage(message);
locatorMap[event.message.id] = narrow;
_addLastInStreamTopic(message.id, message.streamId, message.topic);
case DmMessage():
final narrow = DmNarrow.ofMessage(message, selfUserId: selfUserId);
locatorMap[event.message.id] = narrow;
_addLastInDm(message.id, narrow);
}
lib/model/unreads.dart
Outdated
| if (messageIds.isEmpty) { | ||
| newlyEmptyTopics.add(topic); | ||
| } | ||
| /// Remove any of [idsToRemove] that are in [streams]. |
There was a problem hiding this comment.
nit:
Suggested change
| /// Remove any of [idsToRemove] that are in [streams]. | |
| /// Remove any of [idsToRemove] that are in [streams]. |
rajveermalviya
added
integration review
Fixes zulip#332. Really the same optimization as described for zulip-mobile in zulip/zulip-mobile#4684 , and makes mark-as-read take 0ms (to the nearest ms) down from 3 or 4, in my testing, and so fixes zulip#332.
chrisbobbe
force-pushed
the
pr-unreads-locator-map
branch
from
f3988b0 to
02f9779
Compare
|
Thanks for the review! Revision pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332.
Really the same optimization as described for zulip-mobile in
zulip/zulip-mobile#4684
, and makes mark-as-read take 0ms (to the nearest ms) down from 3 or 4, in my testing, and so fixes #332.