inbox: In dark mode, change channel-header gradient to be less stark#2285
Closed
chrisbobbe wants to merge 2 commits into
Closed
inbox: In dark mode, change channel-header gradient to be less stark#2285chrisbobbe wants to merge 2 commits into
chrisbobbe wants to merge 2 commits into
Conversation
We're about to try changing the top and bottom colors of the channel-header gradient in the inbox, following discussion: https://chat.zulip.org/#narrow/channel/530-mobile-design/topic/channel.20folders.20in.20inbox.3A.20design/near/2432233 We'll do that differently between light and dark mode (in particular we intend to change dark mode but not light mode). That calls for wiring it up through ThemeExtension, which in turn calls for new ChannelColorVariant enum values.
…100% → 0%) From discussion: https://chat.zulip.org/#narrow/channel/530-mobile-design/topic/channel.20folders.20in.20inbox.3A.20design/near/2440597 Done by adding to ChannelColorVariant/ChannelColorSwatch because the color adjustments don't apply uniformly in light and dark modes (in particular we're only changing dark mode).
chrisbobbe
added
integration review
Collaborator
Author
|
Closing as superseded by #2293. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements my proposal in discussion:
#mobile-design > channel folders in inbox: design @ 💬
I'll update this if we settle on something different.
main(100% → 0%)(Solid-colored rows unchanged, still 100% opacity.)
cc @alya