image: Respect iOS "Auto-Play Animated Images" setting on iOS 18+#2288
Merged
Conversation
chrisbobbe
added
integration review
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
rajveermalviya
approved these changes
Apr 28, 2026
Member
rajveermalviya
left a comment
rajveermalviya
left a comment
There was a problem hiding this comment.
Thanks @chrisbobbe! LGTM, moving over to Greg's review.
| // TODO(log) if can't be parsed | ||
| int? get majorVersion => | ||
| // [IosDeviceInfo.systemVersion] is a dotted string, e.g. "17.5.1". | ||
| int.tryParse(systemVersion.split('.').first, radix: 10); |
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Good question. I think this is simple/fast enough that it's fine for it to be a getter.
rajveermalviya
added
integration review
Member
|
Thanks for taking care of this, and thanks @rajveermalviya for the previous review! Looks good; merging. |
gnprice
force-pushed
the
pr-auto-play-animated-images
branch
from
68e8bb1 to
a958851
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1924.