compose box: Show error on sending message when not caught up. #4208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrawal-d
requested review from
gnprice and
chrisbobbe
and removed request for
gnprice
|
Thanks @agrawal-d ! What approach did you find for manually testing this? With a debug build, simply putting the device into airplane mode before launching the app is no good, because then it can't load the JS bundle from Metro. (The app just shows a red error screen on startup.) |
|
I disabled remote JS debugging, this will prevent the red screen error if the JS bundle has been loaded at least once. I went to a narrow, with the internet turned on, so that the messages are cached and then I killed the app. I then turned off the device internet and opened Zulip again. Then I went to the same narrow and tried sending a message. |
Check if we are caught up in the current narrow, and if so, show an error when trying to send a message asking the user to try again after some time. This prevents the user from possibly responding to a very old message when the messages after it have not been loaded yet - this can lead to the reply being out of context without the sender realizing it. Fixes: zulip#3800
Translates the 'Failed to edit message' string in 'handleEdit'.
As Apple puts it: The less text people have to read onscreen, the better. Try to craft a title that avoids adding extra text as a message. https://developer.apple.com/design/human-interface-guidelines/ios/views/alerts/ We can probably improve a lot of the text across our UI, including error messages, including probably still this one. But I think this is slightly better.
The title comes before the message in the UI as presented to the user, and they come in that order in the underlying RN `Alert.alert` function. It's most natural to keep them in that order for this small helper function of ours, too.
|
That works, thanks! Merged, with a couple of additional commits on top. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if we are caught up in the current narrow, and if so, show an
error when trying to send a message asking the user to try again
after some time.
This prevents the user from possibly responding to a very old
message when the messages after it have not been loaded yet - this
can lead to the reply being out of context without the sender
realizing it.
Fixes: #3800