ProfileScreen: Use NavRows and a TextRow instead of ZulipButtons#5688
Open
chrisbobbe wants to merge 1 commit intozulip:mainfrom
Open
ProfileScreen: Use NavRows and a TextRow instead of ZulipButtons#5688chrisbobbe wants to merge 1 commit intozulip:mainfrom
NavRows and a TextRow instead of ZulipButtons#5688chrisbobbe wants to merge 1 commit intozulip:mainfrom
Conversation
Contributor
Author
|
Possibly we want the rows to have icons? I looked to the settings screen and didn't find a pattern to follow; just filed #5687 for that. |
Contributor
Author
In #5687 (comment) @terpimost said it's OK for a row to include or not include an icon; we don't need them to be all-or-nothing. I assume that would apply here too. |
We've been using a `NavRow` and a `SwitchRow` for the first two
interactive items ("Set your status" and "Invisible mode"), and I
think the screen looks more coherent if we use `NavRow`s and a
`TextRow` for these other interactive items too. For one thing, now
all the text on the screen is the same color.
chrisbobbe
force-pushed
the
pr-profile-screen-rows
branch
from
e216c0b to
85b20aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been using a
NavRowand aSwitchRowfor the first two interactive items ("Set your status" and "Invisible mode"), and I think the screen looks more coherent if we useNavRows and aTextRowfor these other interactive items too. For one thing, now all the text on the screen is the same color.