-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Recent Conversations view #1567
Open
sahith-ch
wants to merge
5
commits into
zulip:main
Choose a base branch
from
sahith-ch:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented a new RecentConversationsView in ui_tools/views.py to display recent conversation data fetched via model.py. Updated core.py and ui.py to integrate this view into the main application flow. Modified cli/run.py to support initialization of conversation data, and adjusted keys.py and ui_sizes.py for navigation and layout consistency. Added button support in ui_tools/buttons.py for interacting with conversations. This enhances zulip-terminal’s interactivity by allowing users to view and navigate recent conversations, addressing requirements from issue zulip#1565. Fixes zulip#1565.
Can you remove the non relevant changes from the PR? Also, does this support keyboard navigation? |
Yeh sure I will remove non relevant changes and |
@sahith-ch I left feedback in the channel, since it may be easier to discuss there, and there's a lot of background discussion that I'm not sure if you've read? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
missing feature
A general missing feature, present in another Zulip client
PR awaiting update
PR has been reviewed & is awaiting update or response to reviewer feedback
size: XL
[Automatic label added by zulipbot]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
This PR integrates the recent conversations feature into Zulip-Terminal, allowing users to quickly access their latest chats. This improves usability by reducing navigation time and making it easier to switch between discussions.
External discussion & connections
topic
How did you test this?
Visual changes