-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added four new theme to the theme directory #1568
Conversation
@Gopinath-Mahendiran Could you summarize the differences between the colors used in the existing gruvbox styles and those in the new versions? I'd need to look at the gruvbox variations again (ie. different contrast, etc), or potentially those of other styles, but the idea was that something like the background color could be set for different 'variants', while only needing one theme definition. Please tidy the commits and remove extra changes that are not relevant, and get tests passing, before checking again. It's fine to have the screenshots as examples, but I can't reproduce them with the code as it stands. |
I started a new topic for this in the channel - searching for either the issue or PR number should find it via the topic title. |
1811170
to
f2fff48
Compare
Differences in Gruvbox Variants:
here the different colors used in gruvbox_dark_high_constrast from gruvbox_dark
This table highlights the differences in foreground and background colors for each style between the two themes. The high-contrast theme uses bolder and more vibrant colors, while the original Gruvbox Dark theme uses more subdued tones. |
@neiljp now try recreating it |
bc75ba2
to
04fd0ae
Compare
04fd0ae
to
23a773c
Compare
What does this PR do, and why?
This PR adds four new themes to Zulip Terminal, enhancing user customization options and improving the overall visual experience. The newly introduced themes offer greater flexibility for different user preferences.
Added new theme are
->gruvbox_dark_high_contrast
->gruvbox_dark_low_contrast
-> gruvbox_light_high_contrast
-> gruvbox_light_low_contrast
External discussion & connections
topic
How did you test this?
Self-review checklist for each commit
Visual changes
gruvbox_dark_high_constrast




gruvbox_dark_low_constrast
gruvbox_light_high_constrast
gruvbox_light_low_constrast