Remove travis left out code and update docs. #14784

arpit551 · 2020-04-28T15:23:05Z

Renaming for cleaner CI files is done in #14783
@timabbott can you check this.

Since in travis we don't have root access so we used to add different srv path. As now we shifted our production suites to Circle CI we don't need that code so removed it. Also we used a hacky code in commit-lint-message for travis which is now of no use.

arpit551 · 2020-04-28T15:25:34Z

docs/contributing/zulipbot-usage.md

@@ -85,12 +85,6 @@ assignee(s) if they are still working on the issue.
    issue's current assignee(s) and the "in progress" label to allow others to
    work on an inactive issue.



After this feature is added in zulipbot for Circle CI, we can replace it with Circle CI.

Opened zulip/zulipbot#172 to track this.

docs/contributing/code-reviewing.md

docs/testing/continuous-integration.md

amanagr · 2020-04-28T18:30:46Z

Should we enable the commented nagios test?

# Some of the Nagios tests have been temporarily disabled to work
# around a Travis CI infrastructure issue.
echo; echo "Now running additional Nagios tests"; echo
if ! /usr/lib/nagios/plugins/zulip_app_frontend/check_queue_worker_errors || \
   ! su zulip -c /usr/lib/nagios/plugins/zulip_postgres_appdb/check_fts_update_log; then # || \
#   ! su zulip -c "/usr/lib/nagios/plugins/zulip_app_frontend/check_send_receive_time --site=https://127.0.0.1/api --nagios --insecure"; then
    set +x
    echo
    echo "FAILURE: Nagios checks don't pass:"
    echo
    echo "DEBUG: printing Zulip server's error log:"
    cat /var/log/zulip/errors.log
    exit 1
fi

amanagr · 2020-04-28T18:31:29Z

Also, we can remove the TODO in .config.yml


  - &save_cache_requirements
    save_cache:
      paths:
        - /srv/zulip-venv-cache
      key: v1-venv-base.{{ .Environment.CIRCLE_JOB }}-{{ checksum "requirements/thumbor-dev.txt" }}-{{ checksum "requirements/dev.txt" }}
    # TODO: in Travis we also cache ~/zulip-emoji-cache, ~/node, ~/misc

timabbott · 2020-04-28T18:32:02Z

docs/testing/continuous-integration.md

-* Built/downloaded emoji sprite sheets and data.
-
-This is probably worth eventually adding to the CircleCI caches, but
-because it only saves ~5s, it hasn't been a priority yet.


Can you open an issue for doing this in CircleCI? It seems probably worth tracking; even 5s per job with 5 jobs adds up to a significant amount of runtime, and we have all the tooling to do this in the development environment, so it should be relatively easy.

timabbott · 2020-04-28T18:32:46Z

Merged as the series ending with a6df0b9, thanks @arpit551!

You can see how many hacks Travis CI made us do, as part of the reason I'm happy to be done with it.

arpit551 added 3 commits April 26, 2020 22:55

doc: Update documentation replacing travis with circle ci.

cbc693b

doc: Updated docs for the job xenial-legacy.

9c4ef43

arpit551 commented Apr 28, 2020

View reviewed changes