fix(vite): ensures the paths are correctly formatted for all os #534
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@shivam-sharma7 is attempting to deploy a commit to the Zuplo WWW Team on Vercel. A member of the Team first needs to authorize it. |
shivarm
commented
Jan 16, 2025
|
@mosch actually @dan-lee made some change recent which also not worked for me, you can verify here: https://github.com/shivarm/zudoku/blob/1a3204d76a676965e6a5daa80e4dd59d10b35d59/packages/zudoku/src/vite/plugin-api.ts#L178 |
|
Ah sorry @shivarm, I wanted to fix this in the other PR but it slipped my mind 😵💫 |
No problem let's merge this. |
dan-lee
approved these changes
Jan 21, 2025
|
View your CI Pipeline Execution ↗ for commit a2483e8.
☁️ Nx Cloud last updated this comment at |
|
Thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paths should be correctly formatted, and the import should resolve without errors on all operating systems. This ensures compatibility and avoids issues related to incorrect path formatting
Fixes: #511