Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix prefix lookup in basickv and add corresponding test #134

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

SYaoJun
Copy link
Contributor

@SYaoJun SYaoJun commented Sep 14, 2024

What's changed and how does it work?

  1. add prefixlookup based on pessimistic iterator
  2. add test for prefixlookup BasicKV::PrefixLookup: I notice the founction may return one KV pair. it is designing for that or a bug? #133

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.29%. Comparing base (a19fa4f) to head (addeac5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/btree/BasicKV.cpp 88.88% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   62.23%   62.29%   +0.06%     
==========================================
  Files          84       84              
  Lines        6421     6418       -3     
  Branches     3001     2953      -48     
==========================================
+ Hits         3996     3998       +2     
+ Misses       2074     2060      -14     
- Partials      351      360       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 3868541 into zz-jason:main Sep 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants