Skip to content

Update PredefinedMethodsHelper #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Apr 6, 2025

No description provided.

@StefH StefH self-assigned this Apr 6, 2025
@StefH StefH added the feature label Apr 6, 2025
@StefH StefH requested a review from Copilot April 24, 2025 18:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the PredefinedMethodsHelper and related parser components to enhance the handling of predefined method calls and improve test coverage. Key changes include:

  • A new instance-based implementation for PredefinedMethodsHelper with a configurable dictionary of supported methods.
  • Updated test cases in PredefinedMethodsHelperTests and MethodFinderTest, including renaming test methods for clarity.
  • A refactoring in MethodFinder and ExpressionParser to accommodate the new method helper structure.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/System.Linq.Dynamic.Core.Tests/Parser/PredefinedMethodsHelperTests.cs Added tests for various supported and unsupported method scenarios.
test/System.Linq.Dynamic.Core.Tests/Parser/MethodFinderTest.cs Modified test cases with updated parameter types and method names.
src/System.Linq.Dynamic.Core/Parser/SupportedMethods/MethodFinder.cs Renamed output parameter to "methodOrConstructor" for clarity.
src/System.Linq.Dynamic.Core/Parser/PredefinedMethodsHelper.cs Transitioned from a static helper to an instance helper with a configurable supported methods dictionary.
src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs Integrated the instance PredefinedMethodsHelper and updated method accessibility checks.
src/System.Linq.Dynamic.Core/DynamicClassFactory.cs Updated the call to use the new ObjectInstanceToString property.
Files not reviewed (1)
  • .vscode/tasks.json: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant