Skip to content

Add support for "not in" and "not_in" #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for "not in" and "not_in" #915

wants to merge 1 commit into from

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Apr 25, 2025

No description provided.

@StefH StefH requested a review from Copilot April 25, 2025 11:51
@StefH StefH self-assigned this Apr 25, 2025
@StefH StefH added the feature label Apr 25, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the "not in" and "not_in" operators and updates array initializer syntax in test cases according to the latest language updates. Key changes include

  • Updating existing tests to use the new square bracket array initializer syntax.
  • Adding new tests to verify the correct parsing and behavior of "not in", "not_in", and combined operators.
  • Modifying the core parsing logic in ExpressionParser and Tokenizer to handle the new operators.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
test/System.Linq.Dynamic.Core.Tests/Parser/ExpressionParserTests.cs Updated test array initializers and added new tests for "not in" operator behavior.
test/System.Linq.Dynamic.Core.Tests/ExpressionTests.cs Added tests for "not_in" variants and updated assertions with the new syntax.
src/System.Linq.Dynamic.Core/Tokenizer/TextParser.cs Introduced TokenIsIdentifier and TryGetToken to support new operator detection.
src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs Revised operator parsing logic to support "in", "not in", and "not_in" expressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant