[Draft] Add appveyor ci with multi-targeting project #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
commented
May 22, 2019
| - path: '**\*.nupkg' | ||
| name: nupkg | ||
| - path: '**\*.snupkg' | ||
| name: snupkg |
There was a problem hiding this comment.
qmfrederik
reviewed
May 29, 2019
| '$(TargetFramework)' == 'netstandard1.6' or | ||
| '$(TargetFramework)' == 'netstandard2.0' | ||
| "> | ||
| <PackageReference Include="System.Net.Http" Version="4.3.4" /> |
There was a problem hiding this comment.
These libraries all ship OOB with netstandard2.0. Adding a dependency on these for netstandard2.0 is not required, and will only make the dependency graph more complex. Would it be possible to remove the dependency on these for netstandard2.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Portable libs will be added later if there're no concerns about using a single multi-targeting project.
ci build (from folk repo): https://ci.appveyor.com/project/hanabi1224/html-agility-pack/builds/24739600/artifacts