Skip to content

Add keyboard fire effect - #959

Open
jooj211 wants to merge 1 commit into
1kc:masterfrom
jooj211:add-fire-effect
Open

Add keyboard fire effect#959
jooj211 wants to merge 1 commit into
1kc:masterfrom
jooj211:add-fire-effect

Conversation

@jooj211

@jooj211 jooj211 commented May 11, 2026

Copy link
Copy Markdown

Summary

  • add a keyboard Fire effect driven by the existing custom-frame animation path
  • expose Fire in the device tray menu with classic, custom, and dual custom color options
  • restore Fire from saved app state like the existing Ripple and Wheel effects

Fixes #263
Fixes #41
Addresses the fire-effect portion of #187; macro support is out of scope for this PR.

IssueHunt bounty references:

Tests

  • node --check src/main/animation/animationfire.js
  • node --check src/main/feature/featurefire.js
  • node --check src/main/feature/featureidentifier.js
  • node --check src/main/feature/featurehelper.js
  • node --check src/main/device/razerdevicekeyboard.js
  • node --check src/main/statemanager.js
  • node --check src/main/menu/menubuilderdevice.js
  • git diff --check

IssueHunt Summary

Referenced issues

This pull request has been submitted to:


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Fire effect would be AWESOME Enable fire effect on keyboards like Razer Ornata Chroma.

1 participant