-
Notifications
You must be signed in to change notification settings - Fork 1
Update to upstream oasis3 mct #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-preindustrial+concentrations
Are you sure you want to change the base?
Update to upstream oasis3 mct #342
Conversation
|
!test repro |
|
✅ The Bitwise Reproducibility Check Succeeded ✅ When comparing:
Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-esm1.6-configs/tree/a99602d85a5704c748ff578da601ebb85834c9c0/testing/checksum Test summary: |
blimlim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @manodeep, changes look good to me!
| # oa3-mct v5.0 has multiple options for this | ||
| # $NLOGPRT: The first, second and third numbers on the line below this keyword refer to (i) the | ||
| # debug verbosity, (ii) internal timing statistics and (iii) component load balancing analysis. The | ||
| # information is written by OASIS3-MCT for each component and (optionnally) for each process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # information is written by OASIS3-MCT for each component and (optionnally) for each process. | |
| # information is written by OASIS3-MCT for each component and (optionally) for each process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realised this is copied directly from the docs, so maybe just leave it as it is.
1. Summary:
What has changed?
Swapping over to the latest ESM 1.6 release with upstream oasis3-mct v5.2
Why was this done?
Changing over to a later version of oasis3-mct (our current version is v2.x)
2. Issues Addressed:
3. Dependencies (e.g. on payu, or model)
This change requires changes to (note pull request(s) where relevant):
4. Ad-hoc Testing
What ad-hoc testing was done? How are you convinced this change is correct (plots are good)?
5. CI Testing
!test reprohas been run6. Reproducibility
Is this reproducible with the previous commit? (If not, why not?)
!test repro commithas been run.7. Performance
Has the model performance (say, throughput of model-years/wall-day) changed?
If yes, provide the numbers from your testing. Is the performance better or worse?
8. Manifests
Have you changed the executable, the input files and/or the restart files?
If yes, have you updated the manifests?
To update the manifests, run payu setup (in a cloned copy of your feature branch) with reproducibility tests turned off:
Then commit the newly created manifest files (under manifests/) only to the branch for this PR.
9. Documentation
Is the documentation updated?
10. Merge Strategy