claireyung:dev-MC_4km_jra_ryf+regionalpanan+isf. PR #2#1078
claireyung:dev-MC_4km_jra_ryf+regionalpanan+isf. PR #2#1078chrisb13 wants to merge 6 commits intodev-MC_4km_jra_ryf+regionalpanan+isffrom
Conversation
|
@dougiesquire, I think I've now done what we discussed today. This is now for the ice-shelf version. Can you have a go at resolving the conflicts please? If needed, I imagine we can ask for Claire's help resolving any trickier bits. |
|
As for the non-isf configuration, I've generated repro checksums using Claire's original branch and pushed them to her branch for reference. I'll use these to make sure/document that I don't changes answers while doing the conflict resolution. |
6d4c012 to
0392a72
Compare
|
The |
0392a72 to
7ce6a41
Compare
|
!test repro commit |
|
When comparing:
Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/d60cb09f95af27f0512ef6c6575ca8047be37b48/testing/checksum Test summary: |
|
Some of Claire's inputs are in a project that Note, we'll update this config shortly to use the copies of Claire's files in |
|
The checksums I just committed match those I created using Claire's original branch. UPDATE: this has now been squashed into 8c49aa5, along with the answer-changing changes that to the base branch that were reverted for testing. |
91f710b to
a4c54d6
Compare
7fffbb1 to
26c3d46
Compare
This commit squashes 168 commits made during the original development of this configuration. See #814 for the original 168 commits. The first lines of the original 168 commit messages are as follows: - Add regional panantarctic configuration (1/12th degree/4km setup) (#689) - Update regional panantarctic configuration and ensure it runs - Get rid of some old information in the README - Add ice shelves - 2025-08-25 11:49:52: Run 0 - 2025-08-25 11:55:18: Run 0 - Add ice shelf diag to diagtable - Add ice shelf diag to diagtable, fix name - 2025-08-25 13:27:37: Run 0 - 2025-08-25 14:26:11: Run 0 - 2025-08-26 08:39:13: Run 0 - 2025-08-26 08:49:57: Run 0 - 2025-08-26 08:58:46: Run 0 - 2025-08-26 14:00:06: Run 0 - 2025-08-27 09:01:37: Run 0 - 2025-08-27 09:30:33: Run 0 - Try exe with fatal error mesh/mask inconsistent turned into a warning - 2025-08-27 17:39:24: Run 0 - Add err logs - 2025-08-27 20:10:05: Run 0 - revert atm mesh in nuopc.runconfig to nomask - check_for_nans = .false. - Turn Nan checker back on but versboity on too - 2025-08-28 08:30:37: Run 0 - Add diagnostics of mediator - 2025-09-04 11:09:55: Run 0 - try pr142-10 and no outputs and check for nans = T - 2025-09-05 08:54:40: Run 0 - 2025-09-05 11:40:08: Run 0 - 2025-09-05 12:15:25: Run 0 - 2025-09-07 10:45:45: Run 0 - 2025-09-07 10:55:04: Run 0 - 2025-09-08 19:59:17: Run 0 - 2025-09-08 20:12:06: Run 0 - 2025-09-09 11:52:17: Run 0 - 2025-09-09 12:08:58: Run 0 - 2025-09-09 12:24:29: Run 0 - 2025-09-09 12:33:49: Run 0 - 2025-09-09 14:02:22: Run 0 - 2025-09-09 14:29:18: Run 0 - 2025-09-09 15:22:32: Run 0 - 2025-09-09 15:40:05: Run 0 - 2025-09-09 16:17:47: Run 0 - 2025-09-09 16:48:38: Run 0 - 2025-09-09 17:24:31: Run 0 - 2025-09-10 07:44:08: Run 0 - 2025-09-10 13:51:58: Run 0 - 2025-09-10 14:02:08: Run 0 - 2025-09-10 14:04:43: Run 0 - 2025-09-10 15:35:17: Run 0 - 2025-09-10 17:11:44: Run 0 - 2025-09-10 17:22:09: Run 0 - 2025-09-10 17:45:12: Run 0 - 2025-09-10 23:12:56: Run 0 - 2025-09-11 09:00:46: Run 0 - 2025-09-11 10:32:01: Run 0 - 2025-09-11 14:45:03: Run 0 - 2025-09-11 15:38:56: Run 0 - 2025-09-11 16:14:22: Run 0 - 2025-09-11 16:40:13: Run 0 - 2025-09-11 21:49:18: Run 0 - 2025-09-11 22:41:26: Run 0 - 2025-09-12 08:51:30: Run 0 - 2025-09-12 12:36:17: Run 0 - 2025-09-13 18:35:38: Run 0 - 2025-09-15 08:44:18: Run 0 - 2025-09-15 18:25:30: Run 0 - 2025-09-15 21:35:38: Run 0 - 2025-09-15 21:46:45: Run 0 - payu archive: documentation of MOM6 run-time configuration - Increase timestep to reduce runtime - 2025-09-16 09:48:00: Run 1 - Drop dt again to 300 - 2025-09-16 11:25:29: Run 1 - 2025-09-16 15:19:34: Run 1 - 2025-09-16 15:39:51: Run 1 - 2025-09-16 17:26:16: Run 1 - 2025-09-16 17:45:49: Run 1 - 2025-09-16 18:02:06: Run 1 - 2025-09-16 18:06:34: Run 1 - 2025-09-16 18:09:12: Run 1 - 2025-09-16 18:59:08: Run 1 - 2025-09-16 19:14:00: Run 1 - 2025-09-16 19:34:04: Run 1 - payu archive: documentation of MOM6 run-time configuration - 2025-09-16 21:10:07: Run 1 - 2025-09-16 21:32:03: Run 0 - 2025-09-16 21:35:58: Run 0 - payu archive: documentation of MOM6 run-time configuration - 2025-09-16 22:37:48: Run 0 - 2025-09-16 23:17:44: Run 1 - payu archive: documentation of MOM6 run-time configuration - 2025-09-17 00:03:55: Run 2 - 2025-09-17 08:10:44: Run 2 - 2025-09-17 08:47:39: Run 2 - 2025-09-17 08:59:32: Run 2 - 2025-09-17 09:12:46: Run 2 - 2025-09-17 09:40:11: Run 2 - 2025-09-17 11:50:41: Run 0 - 2025-09-17 12:33:55: Run 0 - 2025-09-17 13:32:53: Run 0 - payu archive: documentation of MOM6 run-time configuration - 2025-09-17 14:20:57: Run 1 - 2025-09-17 14:56:47: Run 0 - 2025-09-17 15:49:21: Run 1 - 2025-09-17 16:05:18: Run 1 - payu archive: documentation of MOM6 run-time configuration - 2025-09-17 17:16:09: Run 2 - 2025-09-17 18:17:02: Run 2 - 2025-09-17 18:31:15: Run 1 - 2025-09-17 21:47:42: Run 1 - 2025-09-17 22:49:39: Run 2 - payu archive: documentation of MOM6 run-time configuration - 2025-09-18 07:41:42: Run 3 - payu archive: documentation of MOM6 run-time configuration - 2025-09-18 13:06:52: Run 4 - 2025-09-18 20:13:15: Run 5 - 2025-09-18 21:58:47: Run 5 - payu archive: documentation of MOM6 run-time configuration - 2025-09-19 09:02:27: Run 0 - payu archive: documentation of MOM6 run-time configuration - 2025-09-19 15:17:35: Run 1 - payu archive: documentation of MOM6 run-time configuration - 2025-09-19 21:15:14: Run 2 - payu archive: documentation of MOM6 run-time configuration - 2025-09-20 02:31:10: Run 3 - 2025-09-20 08:20:46: Run 4 - 2025-09-20 13:56:12: Run 5 - 2025-09-20 19:47:36: Run 6 - 2025-09-21 01:21:12: Run 7 - 2025-09-21 07:06:06: Run 8 - 2025-09-21 12:55:30: Run 9 - 2025-09-21 18:38:29: Run 10 - 2025-09-22 00:34:06: Run 11 - 2025-09-22 06:27:31: Run 12 - 2025-10-01 09:00:41: Run 13 - 2025-10-01 10:44:58: Run 13 - 2025-10-01 14:45:34: Run 13 - payu archive: documentation of MOM6 run-time configuration - 2025-10-03 12:01:58: Run 14 - 2025-10-03 17:19:01: Run 15 - Update file paths to tm70 - update diag table stuff to use make diag table functionality - Update config.yaml with restart - Add ice shelf instructions - delete old stuff - Add ice shelf to readme - replace local exe with prerelease access-om3/pr142-17 - 2025-10-07 11:34:11: Run 0 - remove #override PARALLEL_RESTARTFILES in MOM_override - Replace MOM_input, MOM_override and MOM_override_IS with the MOM_para… - 2025-10-17 10:17:00: Run 0 - 2025-10-17 10:26:28: Run 0 - Update some ice shelf parameters and replace ICs, remove restart - Set up run to start from rest - update instructions - Update core count and PE LAYOUT to be 2600 ocean cores https://github… - Add Kd_interface and remove a few daily diagnostics - 2025-10-23 13:24:26: Run 0 - payu archive: documentation of MOM6 run-time configuration - Prepare for second part of first month run - Testing ice shelf config - Run spin up with Yamazaki ICs - Tuning testing - New control run RYF with somewhat tuned melt parameters and Yamazaki ICs - 2025-11-27 15:46:01: Run 35 - Run RYF out for 5.5 years - Delete ice_shelf_instructions.md -------- Co-authored-by: minghangli-uni <24727729+minghangli-uni@users.noreply.github.com> Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>
26c3d46 to
4cf15dc
Compare
|
@chrisb13, this is ready for review. Could you please take a look? I'll do a merge commit for this one, since it required additional changes requested by Claire I'll update input locations, add MPI flags, update SW pen scheme etc in new PRs. |
0be5cdb to
b1e1493
Compare
…ONS.cff Cherry-picked from claireyung@9e09162
Update to JRA v1-6 as requested by Claire Yung
Update to access-om3/pr142-36 so ICE_SHELF_USTAR_FROM_VEL_BUGFIX parameter is available
Small tidy for consistency with other configs
b1e1493 to
1be8aa9
Compare
Thanks @dougiesquire, sorry for my delay. Is it now in the state that you'd like me to review? I ask as it seems there's been two force pushes after your comment so just double checking. |
|
@chrisb13 yup - ready for review |
|
@chrisb13 and I are reviewing now - looks good, thanks!
To note:
|
|
Yes, in my experience the thermodynamic timestep needs to be the same as DT or not much bigger in the ice shelf config, otherwise it crashes fairly often (more details here claireyung/mom6-panAn-iceshelf-tools#49 ). However, note that DT=150 is only necessary for the first month with the unstable initialisation of ice shelves. After the first month, I recommend swapping to DT=400 and DT_THERM = 400 and coupling timestep 400 which speed things up a bit and is pretty stable. This is in the running instructions - https://access-om3-configs.access-hive.org.au/pr-previews/573/configurations/pan-Antartic/run_panan_isf/ (maybe the link to the running instructions can be made clearer somehow? It is not the only change that is needed after the first month!) With the executable - to run, the ice shelf version requires changes to MOM6 that aren't yet in the main ACCESS-NRI MOM6 branch. Hopefully they make it there at some point, but some of the changes are a bit hacky at the moment and might need some improvement. Some comments here ACCESS-NRI/MOM6#38 |
|
Thanks for your comprehensive answers @claireyung!
Good to know, thanks. As an aside, my understanding is that these changes still need some cleaning up before being merged and eventually ending up in a released executable. Do we have a plan for this? Is it you, or someone at ACCESS-NRI responsible for this? Similarly, has someone taken on the responsibity for pushing some of these back to MOM central (not saying you have to, just wanting to make sure it is clear who should be doing it!)? @chrisb13 - I think we are ready to merge? We will need to remember to update the executable at a later date. |
|
Thanks @claireyung and @helenmacdonald
My memory from chats with @dougiesquire is that our plan is to release the panan+noisf from a cold start and this config from a warm start (given it's expense and the challneges of initilisation). Is my memory correct @dougiesquire? If that's the case, then I think we should move over all the defaults to DT=400 etc.
Ok, so looking at the docs, I see changing the restart and this:
Is there anything else @claireyung?
I think @dougiesquire is aware of this. We've been chatting about which changes may eventually go upstream too (Angus is likely putting a MOM-ocean PR together -- so there is likely an upcoming opportunity fyi @claireyung). Technically, I think we can do an alpha release off a pre-release but I leave to @dougiesquire and @anton-seaice as to whether they'd prefer it based off an actual build release..? I note that it's not currently on @dougiesquire alpha to do list.
Would be helpful to get clarity on the "to note" points we raised here first. Or at least add them to the mega-list. |
I have added them to the mega-list |
Nope. @claireyung's original branch did start from a restart so that is what I originally squashed/rebased to make sure that I could reproduce her answers. But, @claireyung requested on Zulip that the configuration be modified to start cold using her instructions here. I made this change in this commit.
Yes, that will be done in a follow-up PR, along with a few other changes. E.g. see the follow up PR for the non-isf configuration here: #1118
Other that changing a few variables to use their CMIP names, I just copied what Claire had in her
Maybe. But not urgent, and again not in this PR. Please feel free to open an issue.
Yes, I am aware of this as @chrisb13 says and it's on my todo list to get these changes into one of our release branches and eventually upstream. But, as @claireyung mentions, there's a little bit of work to do before they are ready. Alpha releases can use prerelease builds so I don't think this needs to hold us up. |
|
Hmmm, actually after the cold start and parameter updates requested by @claireyung, this now fails after a few hours with: I didn't notice this previously because it does run long enough to update the checksums. Turning off the diagnostics on |
This error is introduced after updating to |
|
The error occurs when trying to write global temperature diagnostics ( which is probably just the same NaN issue manifesting in a different place. |
|
Hi @dougiesquire yeah I get these... You could try Alternatively I believe GFDL people recommend RESCALE_STRONG_DRAG = True and BT_STRONG_DRAG = True NOAA-GFDL/MOM6#971 (comment) which may be relevant. (I haven't tested it yet in this config) |
|
Thanks @claireyung for the suggestions. That issue looks very relevant.
What extent of testing would justify adding these? If this configuration runs with those changes is that sufficient to include them? Are there some outputs/diagnostics we should be looking at (sorry, I know nothing about ice shelves)? |
|
I think if it runs, I'd be happy :) |
|
Thanks heaps @claireyung. Setting
For testing this, I've set up a new branch in the ACCESS-NRI MOM6 fork that is based on the latest NOAA-GFDL/MOM6:dev/gfdl and includes our ACCESS changes and your ice shelf changes. The branch is called Just letting you know as that branch and prerelease could potentially replace ACCESS-NRI/MOM6#14 and ACCESS-NRI/ACCESS-OM3#142 if they suit your needs. |
|
I finally managed to get an ACCESS-OM3 prerelease deployed using the dev/gfdl+access+isf branch. Unfortunately, even with |
|
Bummer. I'm sorry this has been so painful @dougiesquire It's weird because it worked fine with the very similar IAF config. My records of the first month in that IAF config say DT=150 worked. Some options are: try DT=120 (I've done this last year with an RYF when it crashed with dt=150, which i'm pretty sure was the same layout, and it just finished within 10 hours), or we could try dropping the timesteps even smaller and run the first month in two segments (which is annoying for diagnostics, but at least may not crash) Did I muck up something with files - I feel like I saw a notification where you said one of the hashes had changed, but I can't find it now. (Possibly I was hallucinating) Also just clarifying, do you mean it crashes after a few hours of model time or real time? |
No stress at all :)
I've tried reducing the time step (to both 120s and 90s) without success unfortunately.
Model time. Using the dev/gfdl+access+isf branch (
I'm still using your original files in this config (i.e. not the ones on |
See #880 (comment) for why md5 hash changed for OBC forcing
|
The crash still occurs using the input files on There's now very little difference between this configuration and the IAF one @claireyung successfully ran. The main remaining differences are:
I've checked that the additional MOM parameter changes that we're brought in by the rebase are not responsible for the crash. |
|
Hmm. That is quite early to crash. Thanks for the comparison. As for the boundary forcing file, I just copied the RYF version to make the gregorian IAF one and changed the dates (interpolating for Feb 29 if a leap year). So shouldn't have caused the difference, and it looks like the errors were coming from ice-shelfy latitudes not the northern boundary? Just confirming, by checking it's not parameter changes brought in the rebase, you mean that the changes to |
Yup. With |
|
I was able to run @claireyung's IAF config without issue (for one day). But, if I update only the With JRA v1.4 RYF forcing I can run for at least 1 day. I'm trying the full month at the moment. |
A new PR for the alpha release of the regional panan with ice-shelves. This PR allows us to add @claireyung's commits on top of the latest
dev-MC_25km_jra_ryf.ADDED BY DOUGIE: This PR now includes the same commits as #814 but rebased onto an updated dev-MC_4km_jra_ryf+regionalpanan+isf branch
We plan to do a squash merge.
Related: