Conversation
Solely informed by spack-config now
Member
Author
|
@CodeGat don't forget to update the hash of spack in EDIT: Done in f0e4d61 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References ACCESS-NRI/spack-config#41
Closes #349
Background
There is an update to
spack-config(see ACCESS-NRI/spack-config#110), which makes use of theincludes.yaml, and a move away from thespack-enable.bash. This PR updates the workflow to usesetup-env.sh, and adds a new script to set up service users.Furthermore, we revert to essentially pre-
v8behavior in which instead ofbuiltin-spack-packagesbeing a lever to pull inconfig/settings.json, it is informed solely byspack-config.The PR
builtinviasettings.json, now informed byspack-configTesting
Tested in Prerelease via ACCESS-NRI/ACCESS-TEST#65