Corrections so all intensive diagnostics use sea ice area#89
Merged
anton-seaice merged 2 commits intomasterfrom Jan 30, 2026
Merged
Corrections so all intensive diagnostics use sea ice area#89anton-seaice merged 2 commits intomasterfrom
anton-seaice merged 2 commits intomasterfrom
Conversation
Collaborator
Author
|
Example output in /g/data/tm70/as2285/payu/esm1.6/401/401-dev-preindustrial+concentrations/archive/output000/ I only looked as siflfwbot because thats the only one we use 
The diagnostics match closer now: 
|
Collaborator
Author
|
Collaborator
Author
|
Ready to go @blimlim |
blimlim
reviewed
Jan 30, 2026
Collaborator
blimlim
left a comment
blimlim
left a comment
There was a problem hiding this comment.
Thanks @anton-seaice, just had one small question
source/ice_history.F90
Outdated
| call define_hist_field(n_siflsaltbot,"siflsaltbot","kg m^-2 s^-1",tstr2D, tcstr, & | ||
| "Salt Flux from Sea Ice", & | ||
| "area weighted average, positive downward, per unit grid cell area", c1, c0, & | ||
| "area weighted average, positive downward, per sea ice area", c1/dt, c0, & |
Collaborator
There was a problem hiding this comment.
Just wanted to check about the extra 1/dt factor. If the description is correct(?), fsalt_ai should already be in units kgm^-2s^-1:
Line 317 in deed70c
Collaborator
Author
There was a problem hiding this comment.
oops - thanks. Thank should be for siflfwdrain, was a copy paste error !
blimlim
approved these changes
Jan 30, 2026
Collaborator
blimlim
left a comment
blimlim
left a comment
There was a problem hiding this comment.
Thanks @anton-seaice, looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88 - use ice area averages for all intensive (area weighted) cmip variables