Skip to content

Corrections so all intensive diagnostics use sea ice area #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anton-seaice merged 2 commits into from
Jan 30, 2026
Merged

Corrections so all intensive diagnostics use sea ice area #89

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45615d2
Corrections so all intensive diagnostics use sea ice area
anton-seaice Jan 29, 2026
84165db
apply /dt factor to siflfwdrain
anton-seaice Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 12 additions & 22 deletions source/ice_history.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1460,22 +1460,22 @@ subroutine init_hist (dt)

call define_hist_field(n_siflfwdrain,"siflfwdrain","kg m^-2 s^-1",tstr2D, tcstr, &
"Freshwater Flux from Sea-Ice Surface", &
"area weighted average, positive downward, per unit grid cell area", c1, c0, &
"area weighted average, positive downward, per sea ice area", c1, c0, &
ns1, f_siflfwdrain, avg_ice_present=.true., mask_ice_free_points=.true.)

call define_hist_field(n_sipr,"sipr","kg m^-2 s^-1",tstr2D, tcstr, &
"Rainfall Rate over Sea Ice", &
"area weighted average, per unit grid cell area", c1, c0, &
"area weighted average, per sea ice area", c1, c0, &
ns1, f_sipr, avg_ice_present=.true., mask_ice_free_points=.true.)

call define_hist_field(n_siflsaltbot,"siflsaltbot","kg m^-2 s^-1",tstr2D, tcstr, &
"Salt Flux from Sea Ice", &
"area weighted average, positive downward, per unit grid cell area", c1, c0, &
"area weighted average, positive downward, per sea ice area", c1/dt, c0, &
Copy link
Collaborator

@blimlim blimlim Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to check about the extra 1/dt factor. If the description is correct(?), fsalt_ai should already be in units kgm^-2s^-1:

cice5/source/ice_flux.F90

Line 317 in deed70c

fsalt_ai, & ! salt flux to ocean (kg/m^2/s)

Copy link
Collaborator Author

@anton-seaice anton-seaice Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops - thanks. Thank should be for siflfwdrain, was a copy paste error !

ns1, f_siflsaltbot, avg_ice_present=.true., mask_ice_free_points=.true.)

call define_hist_field(n_siflfwbot,"siflfwbot","kg m^-2 s^-1",tstr2D, tcstr, &
"Freshwater Flux from Sea Ice", &
"area weighted average, positive downward, per unit grid cell area", c1, c0, &
"area weighted average, positive downward, per sea ice area", c1, c0, &
ns1, f_siflfwbot, avg_ice_present=.true., mask_ice_free_points=.true.)

call define_hist_field(n_sisaltmass,"sisaltmass","kg m^-2",tstr2D, tcstr, &
Expand Down Expand Up @@ -2686,15 +2686,8 @@ subroutine accum_hist (dt)

if (f_sipr(1:1) /= 'x') then
worka(:,:) = c0
do j = jlo, jhi
do i = ilo, ihi
if (aice(i,j,iblk) > puny) then
! intensive + grid box mean -> weight frain by aice twice (see f_frain_ai)
worka(i,j) = aice(i,j,iblk)*aice_init(i,j,iblk)*frain(i,j,iblk)
endif
enddo
enddo
call accum_hist_field(n_sipr, iblk, worka(:,:), a2D)
! intensive + grid box mean -> weight frain by aice
call accum_hist_field(n_sipr, iblk, aice(:,:,iblk)*frain(:,:,iblk), a2D)
endif

if (f_sifb(1:1) /= 'x') then
Expand Down Expand Up @@ -2730,28 +2723,25 @@ subroutine accum_hist (dt)
endif

if (f_siflsaltbot(1:1) /= 'x') &
! intensive + grid box mean -> weight by aice again
call accum_hist_field(n_siflsaltbot, iblk, aice(:,:,iblk)*fsalt_ai(:,:,iblk), a2D)
! intensive + ice area mean -> use weighted form
call accum_hist_field(n_siflsaltbot, iblk, fsalt_ai(:,:,iblk), a2D)

if (f_sisaltmass(1:1) /= 'x') &
! extensive -> grid box mean
! *ice_ref_salinity*rhoi/c1000 in define_hist_field
call accum_hist_field(n_sisaltmass, iblk, vice(:,:,iblk), a2D) !

if (f_siflfwbot(1:1) /= 'x') &
! intensive + grid box mean -> weight by aice again
call accum_hist_field(n_siflfwbot, iblk, aice(:,:,iblk)*fresh_ai(:,:,iblk), a2D)
! intensive + ice area mean -> use weighted form
call accum_hist_field(n_siflfwbot, iblk, fresh_ai(:,:,iblk), a2D)

if (f_siflfwdrain(1:1) /= 'x') then
worka(:,:) = c0
do j = jlo, jhi
do i = ilo, ihi
if (aice(i,j,iblk) > puny) then
! to-do : drainage from meltpond
! intensive + grid box mean -> weight by aice again
worka(i,j) = aice(i,j,iblk)*(melts(i,j,iblk) * rhos &
+ meltt(i,j,iblk) * rhoi)/dt
endif
! intensive + ice area mean -> use weighted forms
worka(i,j) = (melts(i,j,iblk) * rhos + meltt(i,j,iblk) * rhoi)
enddo
enddo
call accum_hist_field(n_siflfwdrain, iblk, worka(:,:), a2D)
Expand Down