Update install setup#15
Merged
Merged
Conversation
1d59c43 to
44abb0f
Compare
44abb0f to
b026f40
Compare
manodeep
reviewed
Feb 13, 2026
Collaborator
manodeep
left a comment
There was a problem hiding this comment.
Had a few comments but looks fine overall - though, admittedly, I am not up-to-date with what's been going on with python packaging in the last ~5 years (post setuptools)
manodeep
approved these changes
Feb 13, 2026
Collaborator
manodeep
left a comment
There was a problem hiding this comment.
Not sure my approval will count though since I do not have write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft for now.Include optional dependencies:
The last two will be updated to main branches too once merged.
EDIT:
The associated optional dependencies are only required for interactive use (e.g. ARE Jupyter Notebook workflows).
EDIT:
The tool setup is a bit tricky because
esmf-tracedoes not depend on packages such as access-experiment-generator, access-experiment-runner, access-config-utils, or access-profiling in order to run. These packages are independent tools.However in practice, users often install these repos into the same python virtual environment to construct end-to-end workflows for profiling and scaling ACCESS models (e.g. experiment generation -> execution -> trace analysis). Hence to keep packaging semantics correct while still supporting these workflows, I propose the following structure:
pyproject.tomldescribes only the dependencies required to runesmf-traceitself (plus optional dev/test/interactive tooling if needed).The goal is to keep esmf-trace packaging clean so it can be published upstream to Spack, while still supporting common end-to-end ACCESS workflows.