Add geospatial extent to model ouput schema#67
Add geospatial extent to model ouput schema#67joshuatorrance merged 16 commits into66-clone-of-schemafrom
Conversation
aidanheerdegen
left a comment
There was a problem hiding this comment.
Questions and suggestions ...
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@anu.edu.au>
|
Thanks @joshuatorrance! I've taken a quick look at the changes and just had a couple of quick questions:
|
|
* Made copy of 2-0-0 for new version, only updating version number * Add geospatial extent to model ouput schema (#67) * Added files for geospatial extent * CI is failing to install? Updating to latest release * Added exclusions for 2 linting rules, split command over multiple lines * Does this work for adding another directory to run commands over? * Updated 2-1-0 test with new attributes * Updating schema testing to handle multiple versions * Fixed typo * Trying to fix looping in shell script * Added rules to geospatial attributes * Reordered new rules to satisfy formatter * Apply suggestion from @aidanheerdegen Co-authored-by: Aidan Heerdegen <aidan.heerdegen@anu.edu.au> * Added simple tests for global attrs and geospatial attrs * Added some simple tests for geospatial bounds * Changed geospatial_*_units to use const instead of a pattern * Removed examples from now const units * Removed limits on lat/lon values, updated tests --------- Co-authored-by: Aidan Heerdegen <aidan.heerdegen@anu.edu.au> * Add time & time bnds (#70) * Added time and time_bnds * Added option for units of reference datetime to have seconds * Now supporting alternative calendar options from CF. * Added required to time * Moved non-const time attrs into sub-schemas * Added type to time units * Added additional tests. These won't be run yet, should run after merge from neighbouring branch '66-model-ouput-adding-geospatial' * Removed bounds from the required list. * Added a test for missing bounds * Updated calendar recommendations. @blimlim & @aidanheerdegen * Tweaked time.json to satisfy formatter --------- Co-authored-by: Aidan Heerdegen <aidan.heerdegen@anu.edu.au>
Closes #66
Adds the follow attributes to the model output schema:
Details and description are heavily
plagiarisedinspired by the ACDD equivalents.I restricted this schema to require units of
degrees_north/degrees_east. ACDD permits other units.I have also restricted the longitude to -180 to 180. ACDD also allows 0 to 360. Reasoning here is just to keep things simple, if this would be restrictive then it can be relaxed.
number. These are the firstnumbersin the schema - need to check all the downstream tools handle numbers correctly.addmetaneeds a solution for numerical templates see issue & PRaccess-output-data-specificationsmay need an update to the auto-doc generation