-
Notifications
You must be signed in to change notification settings - Fork 0
Add geospatial extent to model ouput schema #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joshuatorrance
merged 16 commits into
66-clone-of-schema
from
66-model-ouput-adding-geospatial
Apr 15, 2026
Merged
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a690bd6
Added files for geospatial extent
joshuatorrance faf68e4
CI is failing to install? Updating to latest release
joshuatorrance e6b7b9c
Added exclusions for 2 linting rules, split command over multiple lines
joshuatorrance aad7489
Does this work for adding another directory to run commands over?
joshuatorrance ed987e8
Updated 2-1-0 test with new attributes
joshuatorrance 8018aab
Updating schema testing to handle multiple versions
joshuatorrance 5ef8d15
Fixed typo
joshuatorrance 3247f46
Trying to fix looping in shell script
joshuatorrance 7e273f0
Added rules to geospatial attributes
joshuatorrance 0c309fc
Reordered new rules to satisfy formatter
joshuatorrance 59a10b6
Apply suggestion from @aidanheerdegen
joshuatorrance a125faa
Added simple tests for global attrs and geospatial attrs
joshuatorrance e8139f9
Added some simple tests for geospatial bounds
joshuatorrance 0180b2a
Changed geospatial_*_units to use const instead of a pattern
joshuatorrance 66ebf18
Removed examples from now const units
joshuatorrance a342d09
Removed limits on lat/lon values, updated tests
joshuatorrance File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
au.org.access-nri/model/output/file-metadata/2-1-0/global/geospatial_lat_max.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "global/geospatial_lat_max.json", | ||
| "title": "geospatial_lat_max", | ||
| "description": "Specifies the northernmost latitude covered by the dataset. Units should be \"degrees North\" and values should be a number equal to or between -90 and 90.", | ||
| "examples": [ 90, 12.98 ], | ||
| "type": "number", | ||
| "maximum": 90, | ||
| "minimum": -90 | ||
|
aidanheerdegen marked this conversation as resolved.
Outdated
|
||
| } | ||
10 changes: 10 additions & 0 deletions
10
au.org.access-nri/model/output/file-metadata/2-1-0/global/geospatial_lat_min.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "global/geospatial_lat_min.json", | ||
| "title": "geospatial_lat_min", | ||
| "description": "Specifies the southernmost latitude covered by the dataset. Units should be \"degrees North\" and values should be a number equal to or between -90 and 90.", | ||
| "examples": [ -90, -57.97 ], | ||
| "type": "number", | ||
| "maximum": 90, | ||
|
aidanheerdegen marked this conversation as resolved.
Outdated
|
||
| "minimum": -90 | ||
| } | ||
9 changes: 9 additions & 0 deletions
9
au.org.access-nri/model/output/file-metadata/2-1-0/global/geospatial_lat_units.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "global/geospatial_lat_units.json", | ||
| "title": "geospatial_lat_units", | ||
| "description": "Units for the latitude axis described in \"geospatial_lat_min\" and \"geospatial_lat_max\" attributes. These should be \"degrees_north\".", | ||
| "examples": [ "degrees_north" ], | ||
| "type": "string", | ||
| "pattern": "degrees_north" | ||
| } |
10 changes: 10 additions & 0 deletions
10
au.org.access-nri/model/output/file-metadata/2-1-0/global/geospatial_lon_max.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "global/geospatial_lon_max.json", | ||
| "title": "geospatial_lon_max", | ||
| "description": "Specifies the easternmost longitude covered by the dataset. Units should be \"degrees East\" and values should be a number equal to or between -180 and 180. Cases where geospatial_lon_min is greater than geospatial_lon_max indicate the bounding box extends from geospatial_lon_max, through the longitude range discontinuity meridian, the antimeridian for -180:180 values, to geospatial_lon_min; for example, geospatial_lon_min=170 and geospatial_lon_max=-175 incorporates 15 degrees of longitude (ranges 170 to 180 and -180 to -175).", | ||
| "examples": [ 180, -152.61 ], | ||
| "type": "number", | ||
| "maximum": 180, | ||
| "minimum": -180 | ||
| } |
10 changes: 10 additions & 0 deletions
10
au.org.access-nri/model/output/file-metadata/2-1-0/global/geospatial_lon_min.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "global/geospatial_lon_min.json", | ||
| "title": "geospatial_lon_min", | ||
| "description": "Specifies the westernmost latitude covered by the dataset. Units should be \"degrees East\" and values should be a number equal to or between -180 and 180. See also geospatial_lon_max.", | ||
| "examples": [ -180, 88.48 ], | ||
| "type": "number", | ||
| "maximum": 180, | ||
| "minimum": -180 | ||
| } |
9 changes: 9 additions & 0 deletions
9
au.org.access-nri/model/output/file-metadata/2-1-0/global/geospatial_lon_units.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "global/geospatial_lon_units.json", | ||
| "title": "geospatial_lon_units", | ||
| "description": "Units for the longitude axis described in \"geospatial_lon_min\" and \"geospatial_lon_max\" attributes. These should be \"degrees_east\".", | ||
| "examples": [ "degrees_east" ], | ||
| "type": "string", | ||
| "pattern": "degrees_east" | ||
| } |
|
joshuatorrance marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.