Skip to content

[ROS 2][grid_map_core] Fix transformed map f0dd780 #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

[ROS 2][grid_map_core] Fix transformed map f0dd780 #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
048153c
Merge branch 'fix/get_transformed_map' into 'master'
maximilianwulf Aug 13, 2020
604b59e
Fix cpplint and uncrustify
kjalloul-anybotics Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions grid_map_core/src/GridMapMath.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ bool getIndexFromPosition(
internal::getVectorToOrigin(offset, mapLength);
Vector indexVector = ((position - offset - mapPosition).array() / resolution).matrix();
index = internal::getIndexFromIndexVector(indexVector, bufferSize, bufferStartIndex);
if (!checkIfPositionWithinMap(position, mapLength, mapPosition)) {return false;}
return true;
return checkIfPositionWithinMap(position, mapLength, mapPosition) && checkIfIndexInRange(index,
bufferSize);
}

bool checkIfPositionWithinMap(
Expand Down
111 changes: 111 additions & 0 deletions grid_map_core/test/GridMapMathTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,10 +286,121 @@ TEST(checkIfPositionWithinMap, EdgeCases)
grid_map::Length mapLength(2.0, 3.0);
grid_map::Position mapPosition(0.0, 0.0);

/*
*
* A (is inside) B (is not inside)
* +-----------------------+
* | |
* | |
* | X |
* | ^ |
* | | |
* | | |
* | <-----+ |
* | Y |
* | |
* | |
* | |
* +-----------------------+
* C (is not inside) D (is not inside)
*
* Resulting coordinates are:
* A: (1.0, 1.5)
* B: (1.0, -1.5)
* C: (-1.0, 1.5)
* D: (-1.0, -1.5)
*
*/

// Noise around A.
EXPECT_TRUE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(1.0, 1.5), mapLength,
mapPosition));
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(1.0 + DBL_EPSILON, 1.5), mapLength,
mapPosition));
EXPECT_TRUE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(1.0 - DBL_EPSILON, 1.5), mapLength,
mapPosition));
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(1.0, 1.5 + DBL_EPSILON), mapLength,
mapPosition));
EXPECT_TRUE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(1.0, 1.5 - DBL_EPSILON), mapLength,
mapPosition));

// Noise around B.
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(1.0, -1.5), mapLength,
mapPosition));
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(1.0 + DBL_EPSILON, -1.5), mapLength,
mapPosition));
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(1.0 - DBL_EPSILON, -1.5), mapLength,
mapPosition));
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(1.0, -1.5 + DBL_EPSILON), mapLength,
mapPosition));
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(1.0, -1.5 - DBL_EPSILON), mapLength,
mapPosition));

// Noise around C.
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(-1.0, 1.5), mapLength,
mapPosition));
EXPECT_TRUE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(-1.0 + DBL_EPSILON, 1.5), mapLength,
mapPosition));
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(-1.0 - DBL_EPSILON, 1.5), mapLength,
mapPosition));
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(-1.0, 1.5 + DBL_EPSILON), mapLength,
mapPosition));
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(-1.0, 1.5 - DBL_EPSILON), mapLength,
mapPosition));

// Noise around D.
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(-1.0, -1.5), mapLength,
mapPosition));
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(-1.0 + DBL_EPSILON, -1.5), mapLength,
mapPosition));
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(-1.0 - DBL_EPSILON, -1.5), mapLength,
mapPosition));
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(-1.0, -1.5 + DBL_EPSILON), mapLength,
mapPosition));
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(-1.0, -1.5 - DBL_EPSILON), mapLength,
mapPosition));

// Extra tests.
EXPECT_FALSE(
grid_map::checkIfPositionWithinMap(
grid_map::Position(-1.0, 1.5), mapLength,
Expand Down
Loading