Repository navigation
Update half factor for Unity BGE - #110
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the simulator’s Passive BGE Unity healing to match the new game description (Unity now heals for full Coalition value rather than half), addressing issue #109.
Changes:
- Adjust Unity BGE self-heal from
(coalition_value + 1)/2tocoalition_value. - Introduce a local variable for the heal amount and update the Unity debug output accordingly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1908
to
+1914
| @@ -1909,9 +1909,9 @@ struct PerformAttack | |||
| if (__builtin_expect(fd->bg_effects[fd->tapi][PassiveBGE::unity] && coalition_value, false) | |||
| && can_be_healed(att_status)) | |||
| { | |||
| _DEBUG_MSG(1, "Unity: %s heals itself for %u\n", | |||
| status_description(att_status).c_str(), (coalition_value + 1)/2); | |||
| att_status->add_hp((coalition_value + 1)/2); | |||
| auto value = coalition_value; // No longer the old (coalition_value + 1)/2 per issue #109 | |||
| _DEBUG_MSG(1, "Unity: %s heals itself for %u\n", status_description(att_status).c_str(), value ); | |||
| att_status->add_hp(value); | |||
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/APN-Pucky/tyrant_optimize/sessions/0b96575c-c882-4843-aee1-954eb3784765 Co-authored-by: APN-Pucky <4533248+APN-Pucky@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #109