[trello.com/c/jVWnkguC] Fix crash in WalletViewControllerBase#898
[trello.com/c/jVWnkguC] Fix crash in WalletViewControllerBase#898Lainaaa merged 1 commit intorelease/3.11.0from
Conversation
dev-adamant-im
added
bug
There was a problem hiding this comment.
Pull request overview
Removes a BalanceRow.reload() call during wallet UI updates in WalletViewControllerBase, likely to avoid a crash triggered by row reloading during updates.
Changes:
- Removed
row.reload()after updating the balance row value/cell.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -491,7 +491,6 @@ extension WalletViewControllerBase { | |||
| isBalanceInitialized: wallet.isBalanceInitialized | |||
| ) | |||
| row.updateCell() | |||
There was a problem hiding this comment.
Removing row.reload() may prevent the table from recalculating the BalanceRow height when row.value?.fiat transitions between nil and non-nil (the row’s height closure depends on that). This can leave the balance cell stuck at the old height after currency rates update. Consider triggering a safe height/layout refresh here (e.g., tableView.beginUpdates()/endUpdates() or another non-crashing row/table refresh mechanism) after updating row.value.
| row.updateCell() | |
| row.updateCell() | |
| if let tableView = self.tableView { | |
| tableView.beginUpdates() | |
| tableView.endUpdates() | |
| } |
No description provided.