Skip to content

[trello.com/c/jVWnkguC] Fix crash in WalletViewControllerBase #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lainaaa merged 1 commit into from
Aug 15, 2025
Merged

[trello.com/c/jVWnkguC] Fix crash in WalletViewControllerBase #898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Adamant/Modules/Wallets/WalletViewControllerBase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,6 @@ extension WalletViewControllerBase {
isBalanceInitialized: wallet.isBalanceInitialized
)
row.updateCell()
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing row.reload() may prevent the table from recalculating the BalanceRow height when row.value?.fiat transitions between nil and non-nil (the row’s height closure depends on that). This can leave the balance cell stuck at the old height after currency rates update. Consider triggering a safe height/layout refresh here (e.g., tableView.beginUpdates()/endUpdates() or another non-crashing row/table refresh mechanism) after updating row.value.

Suggested change
row.updateCell()
row.updateCell()
if let tableView = self.tableView {
tableView.beginUpdates()
tableView.endUpdates()
}

Copilot uses AI. Check for mistakes.
row.reload()
}

fileprivate func makeNodesList() -> UIViewController {
Expand Down