Add support for a info message on the echolink connect page #432
Conversation
Optimize replace \n by relocation Use S_OR to simplify string copy
Fix white space
|
I was able to apply the suggested changes. |
Restore message construction code
Reduce use of strlen() calls.
Add warning messages
Send truncated message (and keep warning log)
More optimization around += change i to offset for clarity. eliminate string dup
use ast_str*
Missing "
Unused offset int
channels/chan_echolink.c
Outdated
| @@ -217,6 +218,7 @@ do not use 127.0.0.1 | |||
|
|
|||
| #define DELIMCHR ',' | |||
| #define QUOTECHR 34 | |||
| #define EL_INIT_BUFFER = sizeof("oNDATA\rWelcome to Allstar Node \rEcholink Node %s\rNumber \r \rSystems Linked:\r") + 300 /* initial string buffer size for ast_str buffer */ | |||
There was a problem hiding this comment.
ast_str will dynamically expand... we don't need to be super precise about how big it is, and this duplicates the phrasing from send_info. I think much of the tree will just start with 256 or something like that
There was a problem hiding this comment.
Do we want it to "make sense" why we started with this "size" or just magic number it?
There was a problem hiding this comment.
You have to pass an initial length. Why not pick a reasonable value.
Fix up comments
|
I was searching this code base an i'll be... they used ast_str... app_rpt/channels/chan_echolink.c Line 2350 in da38bf2 and app_rpt/channels/chan_echolink.c Line 2473 in da38bf2 Thing is:
If you agree this is "wrong", I'll create a PR to fix it. |
alloca allocates on the stack, not from the heap, so no need to free. It can be slightly more dangerous so usually you want to be more careful with the size. alloca should always succeed unless it crashes the program, you can't really handle it. |
All references to "AllStar", not allStar, Allstar, etc
missing node numbers in string init
typo in cp=
fix up more comments - strncat using incorrect length
EL_WELCOME_MESSAGE
no = in define :(
Multi line define :(
formating
Adds a feature to display a set message (from the config file) on the echolink app when connected.