-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for an info message on the EchoLink connect page #432
Merged
Merged
Changes from 14 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
ad73406
Add support for a info message on the echolink connect page
a7773ac
Remove copyright lines
firealarmss a9c9a8e
Refactor buffer modification; add comments for the reasoning behind t…
a53a15c
Use the "proper" comment format
firealarmss c01804b
Update chan_echolink.c
mkmer df3b9fa
Update chan_echolink.c
mkmer c4c2026
Update chan_echolink.c
mkmer 839fd0d
Update chan_echolink.c
mkmer 71ab749
Update chan_echolink.c
mkmer 6c5c03e
Update chan_echolink.c
mkmer 4258f4e
Update chan_echolink.c
mkmer 5ed4981
Update chan_echolink.c
mkmer 9387aed
Update chan_echolink.c
mkmer de9ed60
Update chan_echolink.c
mkmer 68d8e55
Update chan_echolink.c
mkmer c097c0c
Update chan_echolink.c
mkmer cedcae4
Update chan_echolink.c
mkmer 6f03924
Update chan_echolink.c
mkmer be3bee3
Update chan_echolink.c
mkmer aa5ba68
Update chan_echolink.c
mkmer 2ccd7af
Merge branch 'master' into master
mkmer e9bc373
Update chan_echolink.c
mkmer 327dcd9
Update chan_echolink.c
mkmer 901b1a7
Update chan_echolink.c
mkmer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ast_str will dynamically expand... we don't need to be super precise about how big it is, and this duplicates the phrasing from send_info. I think much of the tree will just start with 256 or something like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want it to "make sense" why we started with this "size" or just magic number it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to pass an initial length. Why not pick a reasonable value.