Feature/lint #274

interim17 · 2025-08-02T00:11:14Z

Problem

So this is... big, but apparently our repo is a little messy. T_T

Even with some overrides and some rules silenced, getting eslint and typecheck happy required many, many changes.

At the end of the day we will get:

husky will run lint and typecheck before you can commit
CI/CD will run lint and typecheck on your PR
everything current to this PR will pass those checks

I think it's worth doing and will make our work going forward more sound.

I am going to extensively comment on this PR to try and explain why things are changing if it isn't obvious.

There are a few open questions or things I'm unsure about:

404.js is legacy, but maybe used by gatsby internally. Should we either remove it or write it custom, seems like the text is from the template
Navbar is not currently used anywhere that I can tell. Remove? Context?
I added an override for a lot of rules for the Preview code. It was just too much to handle because it's typed very generally/loosely and I'm less familiar with it.
I updated the mobile view to map over data structures (taggedGene, protein, etc) that are lists, but it was treating as single items. I haven't confirmed yet how they look, may need styling
I added a module declaration for css modules so we can move towards importing them like:
import styles from instead of using require and destructuring the classnames, do we want to go that direction?

A lot of changes are obvious, removing unused stuff and throwing types on things.

New feature (non-breaking change which adds functionality)

netlify · 2025-08-02T00:11:19Z

❌ Deploy Preview for cell-catalog failed. Why did it fail? →

Name	Link
🔨 Latest commit	`3473f2a`
🔍 Latest deploy log	https://app.netlify.com/projects/cell-catalog/deploys/68910cf7852125000832e691

interim17 · 2025-08-02T00:33:29Z

gatsby-config.js

    // },
    plugins: [
-        "gatsby-plugin-react-helmet",
+        "gatsby-plugin-react-helmet-async",


It seems like for SSR the async version of react-helmet is preferred, and is also more maintained. I have yet to confirm what it does, and what this has changed. I just made the linter happy.

The Helmet is an example of something where I am unclear if we are intentionally implementing it or it is a legacy from the template used to start the repo.

interim17 · 2025-08-02T00:33:47Z

src/cms/hooks/useDisableWheel.ts

 const useDisableWheel = () => {
    useEffect(() => {
-        document.addEventListener("wheel", function (event) {
+        document.addEventListener("wheel", function () {


interim17 · 2025-08-02T00:34:20Z

src/cms/preview-templates/DiseaseCatalogPreview.tsx

+const DiseaseCatalogPreview = ({ entry, widgetFor }: TemplateProps) => {
+    const props = {
+        title: entry.getIn(["data", "title"]),
+        content: widgetFor("body"),
+        footerText: entry.getIn(["data", "footer_text"]),
+    };

+    return <DiseaseCatalogTemplate {...(props as any)} />;
+};

-export default DiseaseCatalogPreview;
+export default DiseaseCatalogPreview;


This is a punt, along with the override rules in the eslint config, the preview code is too much to deal with right now.

interim17 · 2025-08-02T00:34:37Z

src/component-queries/DiseaseCellLines.tsx

+    const width = useWindowWidth();
+    const isPhone = width < PHONE_BREAKPOINT;
+
+    const suppressRowClickRef = useRef(false);


needed to pull hooks out of map

interim17 · 2025-08-02T00:35:54Z

src/components/CellLineInfoCard/CellLineInfoCardBase.tsx

+                    // eslint-disable-next-line @typescript-eslint/no-misused-promises
+                    onClick={async () => {
+                        try {
+                            await navigator.clipboard.writeText(href);
                            setShareTooltipText("Copied!");
+                        } catch {
+                            setShareTooltipText("Failed to copy");
+                        } finally {
                            setTimeout(() => {
                                setShareTooltipText("");
                            }, 1000);
-                        });
+                        }


navigator.clipboard.writeText(href) is async. I made one linting rule happy by adding this try/catch, but added an ignore to the other one for now.

interim17 · 2025-08-02T00:40:14Z

src/components/CellLineTable/NormalTableColumns.tsx

+): ColumnsType<any> => {
+    const columns: ColumnsType<any> = [


Tweaking the column typing was one of the more involved changes.

I typed the columns prop in CellLineTable and I'm using the antd type ColumnType and ColumnProps to get the same type-safety we got from this before:
export type CellLineColumns<T> = GetProp<typeof Table<T>, "columns">

Probably more than one way to do this, but everything seems to be working...

interim17 · 2025-08-02T00:41:05Z

src/components/Layout.tsx

-                <html lang="en" />
-                <title>{title}</title>
-                <meta name="description" content={description} />
+            <HelmetProvider>


Wrapping in HelmetProvider seems to be the main difference here. As I said in the write up I'm a little shaky on exactly how this all works, would appreciate feedback.

interim17 · 2025-08-02T00:41:38Z

src/components/Navbar.tsx

-          className={` navbar-start has-text-centered navbar-menu ${
-            isActive && "is-active"
-          }`}
+          className={` navbar-start has-text-centered navbar-menu`}


isActive was never reset, so that classname was never applied. Also is this component going to be used? Doesn't seem to be currently.

interim17 · 2025-08-02T00:42:03Z

src/hooks/useEnv.ts

            setEnv("staging");
        }
-    }, []);
+    }, [hostname]);


Linter didn't like missing dependency in hook

interim17 · 2025-08-02T00:42:15Z

src/pages/404.js

+    <Layout>
+        <div>
+            <h1>NOT FOUND</h1>
+            <p>You just hit a route that doesn&#39;t exist... the sadness.</p>
+        </div>
+    </Layout>


Do we want this?

interim17 · 2025-08-02T00:43:45Z

src/templates/disease-catalog.tsx

    coriellLink: string;
 }
-// eslint-disable-next-line
+


This was a little confusing, we have these eslint comments a few places, but were not running eslint... template legacy? They don't seem necessary with the current config.

I have eslint sent to run in my IDE, so that's probably what the origin of these are

interim17 · 2025-08-02T00:44:02Z

src/templates/gene-name.tsx

    structure,
    isoforms,
-}: GeneNameTemplateProps) => {
+}: GeneFrontMatter) => {


Linter doesn't like extending a type but not adding anything.

interim17 · 2025-08-04T16:21:17Z

FWIW, I'm not sure this branch should really be merged as-is since its so large and failing a CI/CD check. Maybe more of a conversation piece.

I could start with a more minimal set of linting rules (no unused vars/imports) and go from there.

interim17 added 4 commits August 1, 2025 16:32

husky pre-commit

425e733

scripts, config, and library changes for linting and type checking

1dc83f6

add github workflow for typechecking and linting

ded53aa

fix linting and typechecking errors throughout the repo

3bb8d5b

interim17 added 2 commits August 1, 2025 17:17

use gatsby-plugin-react-helmet-async

a14e276

streamline husky pre-commit

42d32a7

interim17 commented Aug 2, 2025

View reviewed changes

src/hooks/useEnv.ts

setEnv("staging");

}

}, []);

}, [hostname]);

Copy link

Contributor Author

interim17 Aug 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter didn't like missing dependency in hook

interim17 commented Aug 2, 2025

View reviewed changes

interim17 added 4 commits August 4, 2025 11:10

install with yarn

03363d9

use yarn in CI/CD script

e8512e3

add package resolutions and move things into dev dependencies

2c9719d

try different minimatch resolution

3473f2a

interim17 closed this Aug 13, 2025

Feature/lint #274

Feature/lint #274

Uh oh!

Conversation

interim17 commented Aug 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Uh oh!

netlify bot commented Aug 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for cell-catalog failed. Why did it fail? →

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

interim17 commented Aug 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

interim17 commented Aug 2, 2025 •

edited

Loading

netlify bot commented Aug 2, 2025 •

edited

Loading