Feature/lint #274
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| module.exports = { | ||
| root: true, | ||
| parser: "@typescript-eslint/parser", | ||
| parserOptions: { | ||
| project: "./tsconfig.json", | ||
| ecmaVersion: "latest", | ||
| sourceType: "module", | ||
| ecmaFeatures: { | ||
| jsx: true, | ||
| }, | ||
| }, | ||
| env: { | ||
| browser: true, | ||
| node: true, | ||
| es6: true, | ||
| }, | ||
| plugins: ["@typescript-eslint", "react", "react-hooks", "unused-imports"], | ||
| extends: [ | ||
| "eslint:recommended", | ||
| "plugin:@typescript-eslint/recommended", | ||
| "plugin:@typescript-eslint/recommended-requiring-type-checking", | ||
| "plugin:react/recommended", | ||
| "plugin:react-hooks/recommended", | ||
| "prettier", | ||
| ], | ||
| rules: { | ||
| "no-unused-vars": "off", | ||
| "@typescript-eslint/no-unused-vars": ["warn"], | ||
| "unused-imports/no-unused-imports": "error", | ||
| "@typescript-eslint/no-floating-promises": "warn", | ||
| "no-extra-boolean-cast": "warn", | ||
| "react/prop-types": "off", | ||
|
|
||
| // Currently this repo uses "any" and is generally loose | ||
| // on typing, so turning off some rules that might be | ||
| // best practice in the long run. | ||
| "@typescript-eslint/no-unsafe-assignment": "off", | ||
| "@typescript-eslint/no-unsafe-member-access": "off", | ||
| "@typescript-eslint/no-unsafe-argument": "off", | ||
| "@typescript-eslint/no-unsafe-return": "off", | ||
| "@typescript-eslint/explicit-module-boundary-types": "off", | ||
| "@typescript-eslint/no-explicit-any": "off", | ||
|
|
||
| // Added css module declartion if we want to move away | ||
| // from using require when importing css class names | ||
| // but turning this off for now | ||
| "@typescript-eslint/no-require-imports": "off", | ||
| }, | ||
| settings: { | ||
| react: { | ||
| version: "detect", | ||
| }, | ||
| }, | ||
| ignorePatterns: ["node_modules/", "public/", ".cache/"], | ||
| // TODO: opted to override linting for the preview templates | ||
| // as its too much to handle during the initial migration | ||
| // They are typed very generally and loosely | ||
| overrides: [ | ||
| { | ||
| files: ["src/cms/preview-templates/**/*.tsx"], | ||
| rules: { | ||
| "@typescript-eslint/no-unsafe-call": "off", | ||
| "@typescript-eslint/no-unsafe-member-access": "off", | ||
| "@typescript-eslint/no-unsafe-assignment": "off", | ||
| "@typescript-eslint/no-unsafe-return": "off", | ||
| "@typescript-eslint/no-explicit-any": "off", | ||
| }, | ||
| }, | ||
| ], | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| name: Lint and Typecheck | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main, production] | ||
| pull_request: | ||
| branches: [main, production] | ||
|
|
||
| jobs: | ||
| lint-and-typecheck: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Use Node.js 18 | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 18 | ||
|
|
||
| - name: Install Yarn | ||
| run: npm install -g yarn | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
|
|
||
| - name: Run ESLint | ||
| run: npm run lint | ||
|
|
||
| - name: Run TypeScript typecheck | ||
| run: npm run typecheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| npm run lint && npm run typecheck || exit 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,73 +1,90 @@ | ||
| { | ||
| "name": "gatsby-starter-decap-cms", | ||
| "description": "Example Gatsby, and Netlify CMS project", | ||
| "version": "1.2.2", | ||
| "author": "Austin Green", | ||
| "dependencies": { | ||
| "@ant-design/icons": "^5.5.1", | ||
| "@reach/router": "^1.3.4", | ||
| "antd": "^5.21.2", | ||
| "decap-cms-app": "^3.0.12", | ||
| "decap-cms-media-library-cloudinary": "^3.0.1", | ||
| "decap-cms-media-library-uploadcare": "^3.0.0", | ||
| "gatsby": "^5.14.0-next.3", | ||
| "gatsby-plugin-image": "^3.13.1", | ||
| "gatsby-plugin-react-helmet-async": "^1.2.3", | ||
| "lodash": "^4.17.15", | ||
| "prop-types": "^15.6.0", | ||
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1", | ||
| "react-helmet-async": "^2.0.5", | ||
| "sass": "^1.43.2", | ||
| "uuid": "^8.0.0" | ||
| }, | ||
| "keywords": [ | ||
| "gatsby" | ||
| ], | ||
| "license": "MIT", | ||
| "main": "n/a", | ||
| "scripts": { | ||
| "clean": "gatsby clean", | ||
| "start": "npm run develop", | ||
| "build": "npm run clean && gatsby build", | ||
| "develop": "npm run clean && gatsby develop", | ||
| "serve": "gatsby serve", | ||
| "format": "prettier --trailing-comma es5 --no-semi --single-quote --write --tab-width 4 \"{gatsby-*.js,src/**/*.js}\"", | ||
| "test": "echo \"Error: no test specified\" && exit 1", | ||
| "dev": "npx concurrently \"npx netlify-cms-proxy-server\" \"npm start -- --progress\"", | ||
| "lint": "eslint src --ext .ts,.tsx", | ||
| "typecheck": "tsc --noEmit", | ||
| "prepare": "husky" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/antd": "^1.0.0", | ||
| "@types/minimatch": "^6.0.0", | ||
| "@types/node": "^20.11.20", | ||
| "@types/react": "^18.2.59", | ||
| "@types/react-dom": "^18.2.19", | ||
| "@types/react-helmet": "^6.1.11", | ||
| "@typescript-eslint/eslint-plugin": "8.34.0", | ||
| "@typescript-eslint/parser": "8.34.0", | ||
| "concurrently": "^9.1.2", | ||
| "eslint": "^8.57.1", | ||
| "eslint-config-prettier": "^10.1.8", | ||
| "eslint-plugin-react": "^7.37.5", | ||
| "eslint-plugin-react-hooks": "^5.2.0", | ||
| "eslint-plugin-unused-imports": "^4.1.4", | ||
| "gatsby-plugin-decap-cms": "^4.0.3", | ||
| "gatsby-plugin-fix-fouc": "^1.0.5", | ||
| "gatsby-plugin-netlify": "^5.0.0", | ||
| "gatsby-plugin-postcss": "^6.13.1", | ||
| "gatsby-plugin-purgecss": "^6.0.0", | ||
| "gatsby-plugin-react-svg": "^3.3.0", | ||
| "gatsby-plugin-sass": "^6.13.1", | ||
| "gatsby-plugin-sharp": "^5.13.1", | ||
| "gatsby-remark-copy-linked-files": "^6.13.1", | ||
| "gatsby-remark-external-links": "^0.0.4", | ||
| "gatsby-remark-images": "^7.13.1", | ||
| "gatsby-remark-line-breaks": "^1.0.0", | ||
| "gatsby-remark-relative-images": "^2.0.2", | ||
| "gatsby-source-filesystem": "^5.13.1", | ||
| "gatsby-transformer-remark": "^6.13.1", | ||
| "gatsby-transformer-remark-frontmatter": "^1.1.0", | ||
| "gatsby-transformer-sharp": "^5.13.1", | ||
| "husky": "^9.1.7", | ||
| "lodash-webpack-plugin": "^0.11.4", | ||
| "netlify-cli": "^17.15.7", | ||
| "postcss": "^8.4.35", | ||
| "prettier": "^2.0.5", | ||
| "typescript": "^5.3.3", | ||
| "typescript-plugin-css-modules": "^5.1.0" | ||
| }, | ||
| "engines": { | ||
| "node": ">= 18.15.0" | ||
| }, | ||
| "resolutions": { | ||
| "cheerio": "1.0.0-rc.12", | ||
| "minimatch": "9.0.1", | ||
| "glob/minimatch": "9.0.1" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like for SSR the async version of react-helmet is preferred, and is also more maintained. I have yet to confirm what it does, and what this has changed. I just made the linter happy.
The Helmet is an example of something where I am unclear if we are intentionally implementing it or it is a legacy from the template used to start the repo.