Skip to content

Conversation

@ascibisz
Copy link
Contributor

@ascibisz ascibisz commented Aug 15, 2025

Problem

Adding some tests to this repo! The part I'm most concerned with is un-nesting the firebase recipes, so that's what this first test file focuses on.

Link to story or ticket

Solution

  • Added tests
  • Added new github action for running tests for every pull request
  • Did a little bit of reorganization / cleanup while I was looking at the recipe loader file

@github-actions
Copy link

github-actions bot commented Aug 15, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-08-20 17:10 UTC

@ascibisz ascibisz marked this pull request as ready for review August 15, 2025 18:34
@ascibisz ascibisz requested a review from rugeli August 15, 2025 18:34
@ascibisz ascibisz linked an issue Aug 15, 2025 that may be closed by this pull request
Comment on lines +17 to +18
- name: Run Linter
run: bun run lint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea to move lint tests here!

Copy link
Contributor

@rugeli rugeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great start! We're one step closer to a stable codebase!

@ascibisz ascibisz merged commit 1c05ce5 into main Aug 20, 2025
2 checks passed
@ascibisz ascibisz deleted the admin/add-tests branch August 20, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Tests

3 participants