adjust suppFigS9F percent cutoff #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcass11
approved these changes
Feb 7, 2025
Collaborator
jcass11
left a comment
jcass11
left a comment
There was a problem hiding this comment.
Looks good to me! Runs without error and udpated figure looks as expected. Nice!
chantelleleveille
approved these changes
Feb 7, 2025
Collaborator
|
Fantastic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: adjust analysis of SuppFigS9F to use symmetric time windows
Previous analysis compared data from first 30% and last 25% of tracks. New version of analysis selects data from first 50% and last 50% of tracks.
Outcome
old plot
new plot
new plot as it looks in figure
Changes
Only 1 file was changed:
nuc_morph_analysis/analyses/volume/figure_5_s9_workflow.pyThe N value in the previous analysis was N=786 (much, much lower than 1166). This is because the time windows chosen previously (first 30% and last 25%) were too short. Note: switching from
digitized_normalized_timetonormalized_timeis a robustness improvement; it prevents rounding errors in binning the normalized time from excluding cells.Tests
pdm run python nuc_morph_analysis/analyses/volume/figure_5_s9_workflow.pyran without error.No need for extensive testing beyond this because this was the only file that was changed.