Skip to content

Commit

Permalink
Merge pull request #2056 from AllenInstitute/bugfix/2056-wb_SplitStim…
Browse files Browse the repository at this point in the history
…setName_is_case_sensitive

WB: fix WB_SplitStimsetName must be case insensitive
  • Loading branch information
t-b authored Mar 13, 2024
2 parents b75e1da + b88070f commit f99b9c6
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Packages/MIES/MIES_WaveBuilder.ipf
Original file line number Diff line number Diff line change
Expand Up @@ -2755,7 +2755,7 @@ Function WB_SplitStimsetName(string setName, string &setPrefix, variable &stimul
setPrefix = ""
stimulusType = CHANNEL_TYPE_UNKNOWN

SplitString/E="(.*)_(DA|TTL)_([[:digit:]]+)" setName, setPrefixString, stimulusTypeString, setNumberString
SplitString/E="(?i)(.*)_(DA|TTL)_([[:digit:]]+)" setName, setPrefixString, stimulusTypeString, setNumberString

if(V_flag != 3)
return NaN
Expand Down
17 changes: 17 additions & 0 deletions Packages/tests/Basic/UTF_Utils.ipf
Original file line number Diff line number Diff line change
Expand Up @@ -7692,3 +7692,20 @@ static Function TestAreIntervalsIntersecting()
Make/FREE data = {{-inf, 3}, {2, inf}}
CHECK(!AreIntervalsIntersecting(data))
End

static Function TestCaseInsensitivityWB_SplitStimsetName()

string setPrefix
variable stimulusType
variable setNumber

WB_SplitStimsetName("formula_DA_0", setPrefix, stimulusType, setNumber)
CHECK_EQUAL_STR(setPrefix, "formula")
CHECK_EQUAL_VAR(stimulusType, CHANNEL_TYPE_DAC)
CHECK_EQUAL_VAR(setNumber, 0)

WB_SplitStimsetName("formula_da_0", setPrefix, stimulusType, setNumber)
CHECK_EQUAL_STR(setPrefix, "formula")
CHECK_EQUAL_VAR(stimulusType, CHANNEL_TYPE_DAC)
CHECK_EQUAL_VAR(setNumber, 0)
End

0 comments on commit f99b9c6

Please sign in to comment.